107212 - FizzillaMach won't quit [Mach]

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Henri Sivonen (:hsivonen)]

Build ID: CVS build, pulled on 2001-10-27 after the Mach-O changes landed on the
trunk

Reproducible: Always

Steps to reproduce:
1) Build & lauch FizzillaMach
2) Select Quit from the Mozilla menu.

Actual results:
The app does not quit.

Expected results:
Expected the app to quit.

Comment 1

[sairuh (rarely reading bugmail)]

don't think i've access to this type of build [correct me if i'm wrong, tho'].
nor do i have a build system setup for mac os x. :(

zach, feel free to punt qa ownership as needed...

Comment 2

[sairuh (rarely reading bugmail)]

->pink to triage.

Comment 3

[Mike Pinkerton (not reading bugmail)]

mine.

Comment 4

[Zach Lipton [:zach]]

I am seeing this, so I'll take qa

Comment 5

[Henri Sivonen (:hsivonen)]

Removing qawanted--this bug doesn't need it as per the definition of the keyword.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The latest patch on bug 109165, plus a patch that I'm about to attach here,
fixes this bug.  The nsMenuBarX dispatching of commands for the Preferences/Quit
items was not handling the command attribute like the nsMenuItemX code.  I
refactored the code so they use the same method.  However, there's a slight
inconsistency with return values in error cases -- I made the helper function do
what the nsMenuItemX code did (nsEventStatus_eConsumeNoDefault), but I left
nsMenuBarX::ExecuteCommand returning nsEventStatus_eIgnore.  I'm also slightly
disturbed that nsMenuItemX::DoCommand is returning an nsEventStatus for an
nsresult return type, but I left that alone too.

Comments?  Reviews?  (This won't break FizillaCFM, will it?  It should probably
be tested there...)

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch fixing nsMenuBarX::ExecuteCommand to check command attribute

Comment 8

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 57497 [details] [diff] [review]
patch fixing nsMenuBarX::ExecuteCommand to check command attribute

looks good to me, r=pink

Comment 9

[Simon Fraser [no longer active]]

Comment on attachment 57497 [details] [diff] [review]
patch fixing nsMenuBarX::ExecuteCommand to check command attribute

sr=sfraser

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Taking

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in 2001-11-13 17:53 PDT.

Comment 12

[Henri Sivonen (:hsivonen)]

Verified that this now works. Thanks.