1072125 - [Settings] label and carrier name in "Network operators in the area" out of place

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Eric Chang [:ericcc] [:echang]]

Attachment: 2014-09-24 14.11.05.jpg

### STR
1. Settings -> Cellular & DAta -> Network Operator
2. Turn offf Automatical selection
3. Tap Search again to get a list of operators

### Actual
See 2014-09-24 14.11.05.jpg

### Version
Gaia-Rev        b542080231bb9cdbdb282ab926965ad3f91f7460
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-aurora/rev/d614ae398c03
Build-ID        20140923155123
Version         34.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  27
FW-Date         Thu Sep  4 14:59:02 CST 2014
Bootloader      L1TC10011800

Comment 1

[Eric Chang [:ericcc] [:echang]]

[Blocking Requested - why for this release]: UI Regression

Comment 2

[Eric Chang [:ericcc] [:echang]]

Attachment: SettingsManual.jpg

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on master (2.2)

Arthur, can you help me review this small patch ? THanks :)

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8494941 [details] [review]
patch on master (2.2)

Looks good to me, thanks!

Comment 5

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks all, this patch was merged into Gaia/master (2.2) : https://github.com/mozilla-b2g/gaia/commit/278577d42e016eedf320a906c36df069b1e564e8

Comment 6

[howie [:howie]]

Triage: regression, blocking.

Comment 7

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8494941 [details] [review]
patch on master (2.2)

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Users would get confused because UI is wrong.
[Testing completed]: no
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: no

Comment 8

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/d3ad00b20a61b5af30cb3ea255aeae7fcccfc73d

Comment 9

[Yeojin Chung [:YeojinC]]

This issue is verified on Flame 2.2 and 2.1:

Flame 2.2 KitKat Base (319mb)(Full Flash)
  
Environmental Variables:
Device: Flame 2.2 Master
BuildID: 20141002093155
Gaia: 191d805f4911628d37a8a90a1e23a6013995138f
Gecko: 5d6ec4dddf14
Gonk: 2c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0
  
Flame 2.1 KitKat Base (319mb)(Full Flash)

Environmental Variables:
Device: Flame 2.1
BuildID: 20141002000202
Gaia: 94dcc25f2e34a4900ea58310c26be52bcb089161
Gecko: baaa0c3ab8fd
Gonk: 2c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

The operators and status are displayed properly.