Closed Bug 1072126 Opened 6 years ago Closed 6 years ago

B2G RIL: merge duplicated lines for STK icon loading in ril_worker

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: vicamo, Assigned: vicamo)

References

Details

Attachments

(1 file, 2 obsolete files)

+++ This bug was initially created as a clone of Bug #935843 +++
Attached patch patch (obsolete) — Splinter Review
Attachment #8494332 - Flags: review?(htsai)
Comment on attachment 8494332 [details] [diff] [review]
patch

Review of attachment 8494332 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #8494332 - Flags: review?(htsai) → review+
Attached patch patch (obsolete) — Splinter Review
Update r=hsinyi only. Try: https://tbpl.mozilla.org/?tree=Try&rev=0bb8c5521b3b
Attachment #8494332 - Attachment is obsolete: true
Attachment #8494477 - Flags: review+
Comment on attachment 8494477 [details] [diff] [review]
patch

Review of attachment 8494477 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ +10524,5 @@
>      return method.call(this, cmdDetails, ctlvs);
>    },
>  
> +  loadIconIfNecessary: function(cmdDetails, ctlvs, ret) {
> +    let ctlv = StkProactiveCmdHelper.searchForTag(COMPREHENSIONTLV_TAG_ICON_ID, ctlvs);

should be |this.context.Stk....|.
Attached patch patch : v2Splinter Review
Address comment 4.
Attachment #8494477 - Attachment is obsolete: true
Attachment #8495085 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/90e51af4279a
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.