1072126 - B2G RIL: merge duplicated lines for STK icon loading in ril_worker

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Vicamo Yang [:vicamo][:vyang]]

+++ This bug was initially created as a clone of Bug #935843 +++

Comment 1

[Vicamo Yang [:vicamo][:vyang]]

Attachment: patch

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8494332 [details] [diff] [review]
patch

Review of attachment 8494332 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Attachment: patch

Update r=hsinyi only. Try: https://tbpl.mozilla.org/?tree=Try&rev=0bb8c5521b3b

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 8494477 [details] [diff] [review]
patch

Review of attachment 8494477 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ +10524,5 @@
>      return method.call(this, cmdDetails, ctlvs);
>    },
>  
> +  loadIconIfNecessary: function(cmdDetails, ctlvs, ret) {
> +    let ctlv = StkProactiveCmdHelper.searchForTag(COMPREHENSIONTLV_TAG_ICON_ID, ctlvs);

should be |this.context.Stk....|.

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

Attachment: patch : v2

Address comment 4.

Comment 6

[Vicamo Yang [:vicamo][:vyang]]

https://tbpl.mozilla.org/?tree=Try&rev=1465ae698553

Comment 7

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/integration/b2g-inbound/rev/90e51af4279a

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/90e51af4279a