1072143 - [LockScreen] Add |transferOut| method in LockScreenStateManager

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Greg Weng [:snowmantw][:gweng][:λ]]

In Bug 1062549 we've found the state machine now lacks the method for transferring out from a specific state. This should be implemented to avoid duplicately put code in each state.

Comment 1

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

Add the method first, and I think we can fire another bug to use it.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8500846 [details] [review]
Patch

We need to work on better testing strategy of the promise chain. Let's talk about this on Monday, thanks!

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

We need this to add the proper fix for Bug 1075389.

Comment 4

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8500846 [details] [review]
Patch

Updated according to reviewing opinions.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8500846 [details] [review]
Patch

Please address the reivew comments.

Comment 6

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8500846 [details] [review]
Patch

Updated and set review again, thanks.

Comment 7

[Greg Weng [:snowmantw][:gweng][:λ]]

Gaia-Try is green: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=f356bc976c1e

Comment 8

[Greg Weng [:snowmantw][:gweng][:λ]]

I have found some visual regression would happen when you power off/on it transiently. Discussed with Tim and eased it, but there is still some issue need to be solved. One left issue is although I can cancel all animation while sleep the screen, the animation still need some very short time to perform, so if user turn it on/off/on quickly there would be some delayed step show the panel at the previous position.

A possible solution is to keep the screen slept before the animation done. But I don't know from our current code flow how to do that without too much modification, especially I don't want to change any code in screen manager for this patch...

Comment 9

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8500846 [details] [review]
Patch

Since I fix the regression, set review again.

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8500846 [details] [review]
Patch

Sorry for the delay. Let's figure out what to move to the transferOut functions in next patches.

Comment 11

[Greg Weng [:snowmantw][:gweng][:λ]]

It only failed at Gaia build test (which is totally irrelevant and it's timeout issue):

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=d7d08b4ed294

So I would land this patch.

Comment 12

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/b59c013f706e6fd68af2f24b3077497293f66d88

Hope it would not be backed out.