1072161 - Emphasise treeherder links in Try server hghook response & fix links for try-comm-central

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect, P1)

Description

[Ed Morley [:emorley]]

Bug 1044995 added links to treeherder to the response returned from hg.mozilla.org when people make a push to try.

It's now time to adjust the wording added there to reflect that treeherder is no longer experimental & to encourage more people to give it a try over TBPL.

Comment 1

[Ed Morley [:emorley]]

Attachment: hghooks: Emphasise treeherder Try URLs & fix for try-comm-central

* Emphasise treeherder over TBPL, since the treeherder transition is imminent.
* s/thunderbird-try/try-comm-central/ for treeherder, now that it uses the
  hg/buildbot name (bug 1035222).
* Slight refactor to reduce repetition.

Comment 2

[Ed Morley [:emorley]]

I should add bug 1072162 will make the TBPL links go away entirely (so the hardcoding of tbpl_name will go away), and more try-type repos are likely for the future - so the refactoring should make things simpler long term.

Comment 3

[Ed Morley [:emorley]]

Comment on attachment 8494451 [details] [diff] [review]
hghooks: Emphasise treeherder Try URLs & fix for try-comm-central

(Just spotted gps' away message)

Comment 4

[Ed Morley [:emorley]]

Spelling mistake of 'deprecated' fixed locally.

Comment 5

[hwine]

Comment on attachment 8494451 [details] [diff] [review]
hghooks: Emphasise treeherder Try URLs & fix for try-comm-central

Review of attachment 8494451 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, even a PEP-8 change ;)

Comment 6

[Ed Morley [:emorley]]

Comment on attachment 8494451 [details] [diff] [review]
hghooks: Emphasise treeherder Try URLs & fix for try-comm-central

https://hg.mozilla.org/hgcustom/version-control-tools/rev/4da07a8e33fa

Comment 7

[Ed Morley [:emorley]]

Tests pass:
https://ci.mozilla.org/job/version-control-tools/118/