The default bug view has changed. See this FAQ.

Emphasise treeherder links in Try server hghook response & fix links for try-comm-central

RESOLVED FIXED

Status

Developer Services
Mercurial: hg.mozilla.org
P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

Details

(Whiteboard: [treeherder])

Attachments

(1 attachment)

Bug 1044995 added links to treeherder to the response returned from hg.mozilla.org when people make a push to try.

It's now time to adjust the wording added there to reflect that treeherder is no longer experimental & to encourage more people to give it a try over TBPL.
Whiteboard: [treeherder]
Created attachment 8494451 [details] [diff] [review]
hghooks: Emphasise treeherder Try URLs & fix for try-comm-central

* Emphasise treeherder over TBPL, since the treeherder transition is imminent.
* s/thunderbird-try/try-comm-central/ for treeherder, now that it uses the
  hg/buildbot name (bug 1035222).
* Slight refactor to reduce repetition.
Attachment #8494451 - Flags: review?(gps)
I should add bug 1072162 will make the TBPL links go away entirely (so the hardcoding of tbpl_name will go away), and more try-type repos are likely for the future - so the refactoring should make things simpler long term.
Summary: Emphasise treeherder links in Try server hghook response → Emphasise treeherder links in Try server hghook response & fix links for try-comm-central
Comment on attachment 8494451 [details] [diff] [review]
hghooks: Emphasise treeherder Try URLs & fix for try-comm-central

(Just spotted gps' away message)
Attachment #8494451 - Flags: review?(hwine)
Spelling mistake of 'deprecated' fixed locally.
Comment on attachment 8494451 [details] [diff] [review]
hghooks: Emphasise treeherder Try URLs & fix for try-comm-central

Review of attachment 8494451 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, even a PEP-8 change ;)
Attachment #8494451 - Flags: review?(hwine) → review+
Comment on attachment 8494451 [details] [diff] [review]
hghooks: Emphasise treeherder Try URLs & fix for try-comm-central

https://hg.mozilla.org/hgcustom/version-control-tools/rev/4da07a8e33fa
Attachment #8494451 - Flags: review?(gps)
Tests pass:
https://ci.mozilla.org/job/version-control-tools/118/
Depends on: 1074718
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Product: Release Engineering → Developer Services
You need to log in before you can comment on or make changes to this bug.