1072231 - [soft-home-button] Airplane mode activated page truncated when trying to turn on Wi-Fi hotspot

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Eric Chang [:ericcc] [:echang]]

Attachment: 2014-09-21-09-03-08.png

### STR
1. Turn on soft home button.
2. Turn on airplan mode. 
3. Turn on Wi-Fi hotspot in Internet sharing

### Actual 
See 2014-09-21-09-03-08.png

### Version
Gaia-Rev        b542080231bb9cdbdb282ab926965ad3f91f7460
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-aurora/rev/d614ae398c03
Build-ID        20140923155123
Version         34.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  27
FW-Date         Thu Sep  4 14:59:02 CST 2014
Bootloader      L1TC10011800

Comment 1

[:Eli Perelman]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24387

Comment 2

[Etienne Segonzac (:etienne)]

Comment on attachment 8494570 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24387

The css variable work is starting to pay off :)

(the amount of different dialogs in the system app is crazy!)

Comment 3

[:Eli Perelman]

(In reply to Etienne Segonzac (:etienne) from comment #2)
> The css variable work is starting to pay off :)
> 
> (the amount of different dialogs in the system app is crazy!)

Totally agree, I wish we had a common API for creating all these dialogs.

Comment 4

[:Eli Perelman]

Try run: https://tbpl.mozilla.org/?rev=69ec868b16b0288aa11cd6e699a26b4217f19958&tree=Gaia-Try

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/2ba5bbb9ddf38850878913da2bf434d2cbe8ab70

Comment 6

[:Eli Perelman]

Comment on attachment 8494570 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24387

Requesting uplift to v2.1 for UX polish.

[Bug caused by] (feature/regressing bug #): bug 1036339
[User impact] if declined: User will see a truncated dialog box with a difficult to press "close" button
[Testing completed]: manually tested, no new tests
[Risk to taking this patch] (and alternatives if risky): very low, single CSS change affecting height of generic dialogs
[String changes made]: n/a

Comment 7

[Gregor Wagner [:gwagner]]

Broken feature

Comment 8

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/df567808f51a8c7c33b3651542c67a277940d04d

Comment 9

[Yeojin Chung [:YeojinC]]

This issue is verified on Flame 2.2 and Flame 2.1:

Flame 2.2 KitKat Base (319mb)(Full Flash)
  
Environmental Variables:
Device: Flame 2.2 Master
BuildID: 20141002093155
Gaia: 191d805f4911628d37a8a90a1e23a6013995138f
Gecko: 5d6ec4dddf14
Gonk: 2c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0
  
Flame 2.1 KitKat Base (319mb)(Full Flash)

Environmental Variables:
Device: Flame 2.1
BuildID: 20141002000202
Gaia: 94dcc25f2e34a4900ea58310c26be52bcb089161
Gecko: baaa0c3ab8fd
Gonk: 2c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

The screen is shifted up and the "OK" button is shown properly.

Comment 10

[Kevin Grandon :kgrandon]

Integration test added in bug 1077579.