1072279 - Fix the annoying scollbars in Loop desktop conversation window

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

This applies to the incoming call and the feedback form views.

Comment 1

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: Prevent unnecessary scrollbars in Loop conversation window.

Fixed the styles, updated UI showcase.

Comment 2

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: removed_scrollbars_feedback.png

Removal of scrollbars for feedback form.

Comment 3

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: fixed_scrollbars_incoming.png

Removed scrollbars for incoming calls.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 8494482 [details] [diff] [review]
Prevent unnecessary scrollbars in Loop conversation window.

Review of attachment 8494482 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=Standard8

Comment 5

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/bdfa41b9d42f

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bdfa41b9d42f

Comment 7

[u279076]

Untracking for QE verification. Please needinfo me to request testing.

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8494482 [details] [diff] [review]
Prevent unnecessary scrollbars in Loop conversation window.

Approval Request Comment
Uplift request for patches staged and tested on Fig

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/97132a8f56dd

Comment 10

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8494482 [details] [diff] [review]
Prevent unnecessary scrollbars in Loop conversation window.

I worked with Randell and Maire on uplifting a large number of Loop bugs at once. All of the bugs have been staged on Fig and tested by QE before uplift to Aurora. As well, all of the bugs are isolated to the Loop client. Randell handled the uplift with my approval. I am adding approval to the bug after the fact for bookkeeping.