Perma-orange browser_action_searchengine.js | Test timed out - expected PASS

RESOLVED FIXED in Firefox 35

Status

()

Firefox
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Tomcat, Assigned: Unfocused)

Tracking

unspecified
Firefox 35
x86
Linux
Points:
1
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

4 years ago
Ubuntu VM 12.04 fx-team pgo test mochitest-e10s-browser-chrome-1 on 2014-09-24 04:44:17 PDT for push 251da0912168

slave: tst-linux32-spot-491

https://tbpl.mozilla.org/php/getParsedLog.php?id=48767423&tree=Fx-Team


31 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_action_searchengine.js | Test timed out - expected PASS
Assignee: nobody → bmcbride
Status: NEW → ASSIGNED
Points: --- → 1
Flags: qe-verify-
Flags: firefox-backlog+
Created attachment 8494531 [details] [diff] [review]
Patch v1

I hate Linux.
Attachment #8494531 - Flags: review?(mak77)
Attachment #8494531 - Flags: review?(mak77) → review+
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)

Updated

4 years ago
Blocks: 1067888
Keywords: intermittent-failure
Summary: Intermittent browser_action_searchengine.js | Test timed out - expected PASS → Perma-orange browser_action_searchengine.js | Test timed out - expected PASS
Added to IT 35.2 as it blocks Bug 1067888.
Iteration: --- → 35.2
Created attachment 8494888 [details] [diff] [review]
Patch v2

As discussed on IRC, let's remove this footgun.
Attachment #8494531 - Attachment is obsolete: true
Attachment #8494888 - Flags: review?(mak77)
Comment on attachment 8494888 [details] [diff] [review]
Patch v2

Review of attachment 8494888 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/general/browser_action_searchengine.js
@@ +31,5 @@
>    gURLBar.focus();
>    gURLBar.value = "open a searc";
>    EventUtils.synthesizeKey("h" , {});
>    yield promiseSearchComplete();
> +  yield promisePopupShown(gURLBar.popup);

Doesn't the changes in head.js make this unnecessary now?
Attachment #8494888 - Flags: review?(mak77) → review+
Er, yes. I'd meant to delete that (leftover from the first patch).
Created attachment 8495211 [details] [diff] [review]
Patch v3

*sigh* So, that previous patch helped. But turns out it doesn't fully fix it.

At this point I'm just giving up, given how much time I've sunk into this. Linux is known to be fragile when it comes to both popups and focus, and I don't think we gain anything by dedicating more time to the Linux-only intermittent issues of these tests. Therefore, I think we should just skip them on Linux.
Attachment #8494888 - Attachment is obsolete: true
Attachment #8495211 - Flags: review?(mak77)
Comment on attachment 8495211 [details] [diff] [review]
Patch v3

Review of attachment 8495211 [details] [diff] [review]:
-----------------------------------------------------------------

why browser_autocomplete_a11y_label.js and browser_action_keyword.js are not failing like this test?
is there anything we do differently here?
If I look at them, in those 2 tests you first type in the autocomplete and then wait for the popup. in this test you do the opposite, so the event listener is set at a different time.

That said, I'm fine to disable these if we get a bug filed to investigate this specific failure and make promiseSearchComplete infallible.

PS: this implementation I found uses executeSoon: http://mxr.mozilla.org/mozilla-central/source/browser/base/content/test/newtab/browser_newtab_search.js#376
would be worth to see if adding executeSoon to promisePopupShown (thus 2 ticks, 1 for soon and 1 for resolution) solves the perma orange on Try, just to have some additional data for the bug you are going to file.

::: browser/base/content/test/general/browser.ini
@@ +106,2 @@
>  [browser_action_searchengine.js]
> +skip-if = os == "linux" # Bug ????? - focus and popup issues on Linux

I'd be very happy if you'd file a bug to fix promiseSearchComplete and you'd annotate the bug # here and just above promiseSearchComplete

why are you not skipping browser_autocomplete_a11y_label.js too? It looks like doing the same.

::: browser/base/content/test/general/head.js
@@ +737,5 @@
>    return promisePopupEvent(popup, "hidden");
>  }
>  
>  let gURLBarOnSearchComplete = null;
>  function promiseSearchComplete() {

please add a scary warning above this pointing to the newly filed bug for promiseSearchComplete on Linux, and explaining using this is not orange-safe on Linux.

@@ +755,5 @@
> +    }
> +  }).then(() => {
> +    // On Linux, the popup may or may not be open at this stage. So we need
> +    // additional checks to ensure we wait long enough.
> +    return promisePopupShown(gURLBar.popup);

I *think* you might even do
resolve(promisePopupShown(...
Attachment #8495211 - Flags: review?(mak77) → review+
Depends on: 1073339
(In reply to Marco Bonardo [::mak] (needinfo? me) from comment #10)
> why are you not skipping browser_autocomplete_a11y_label.js too? It looks
> like doing the same.

That test doesn't try to interact with the result - it only inspects it. It's interacting with the result that (AFAICT) fails.
(Reporter)

Comment 13

4 years ago
https://hg.mozilla.org/mozilla-central/rev/6e276e9adae2
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
You need to log in before you can comment on or make changes to this bug.