Closed
Bug 107244
Opened 23 years ago
Closed 22 years ago
Input elements not painted when in a SPAN with background-color set
Categories
(Core :: Layout: Form Controls, defect, P2)
Core
Layout: Form Controls
Tracking
()
RESOLVED
FIXED
mozilla1.0
People
(Reporter: rzach, Assigned: dbaron)
Details
Attachments
(5 files)
975 bytes,
text/html
|
Details | |
14.81 KB,
patch
|
Details | Diff | Splinter Review | |
391 bytes,
text/html
|
Details | |
8.30 KB,
patch
|
rods
:
review+
waterson
:
superreview+
asa
:
approval+
|
Details | Diff | Splinter Review |
330 bytes,
text/html
|
Details |
INPUT elements don't get painted if enclosed in a SPAN which has its background-color set. It seems they get painted beneath the background of the SPAN. I'll attach a testcase. This breaks a major function of WebCT, a web-based course management system, and is cited as one of the reasons they currently don't support Mozilla (see http://www.webct.com/>) Win 2000, 20011027 build, but also observed with recent Linux builds.
Reporter | ||
Comment 1•23 years ago
|
||
Comment 2•23 years ago
|
||
ccing rods. This seems like a form controls problem...
Assignee | ||
Comment 3•23 years ago
|
||
Assignee | ||
Updated•23 years ago
|
Status: NEW → ASSIGNED
Component: Style System → HTML Form Controls
Priority: -- → P2
Target Milestone: --- → mozilla0.9.6
Assignee | ||
Comment 4•23 years ago
|
||
We should check if other controls (combobox, list, file, button, etc.) have this problem...
Comment 5•23 years ago
|
||
Looks right r=rods (I know selects don't have the same problem)
Comment 6•23 years ago
|
||
Sure, sr=waterson. Why doesn't nsLeafFrame::Paint() just call nsFrame::Paint() itself? Also, you're inconsistent with constants on the LHS of equality tests (e.g., |aWhichLayet == BLAH| vs. |NS_OK == rv|), which is surprising for you, dbaron. ;-)
Assignee | ||
Comment 7•23 years ago
|
||
I converted my |NS_OK == rv| to |NS_SUCCEEDED(rv)| and filed bug 108310 on the bogus nsresult return values in GetFrameForPoint and bug 108311 on the weirdness in nsLeafFrame::Paint.
Assignee | ||
Comment 8•23 years ago
|
||
Fix checked in 2001-11-02 22:23 PDT.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 9•23 years ago
|
||
verified fixed on win2000 buildID: 2001-11-08-06-trunk macOS9.1 buildID: 2001-11-08-08-trunk
Status: RESOLVED → VERIFIED
Comment 10•22 years ago
|
||
select, button and button on file control also have this problem. Should reopen this bug.
Assignee | ||
Comment 11•22 years ago
|
||
Comment on attachment 77372 [details]
Testcase of button, select and file
Select looks fine to me.
Assignee | ||
Comment 12•22 years ago
|
||
... because I have an un-checked-in patch to nsComboboxControlFrame.cpp in my tree.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 13•22 years ago
|
||
Assignee | ||
Updated•22 years ago
|
Target Milestone: mozilla0.9.6 → mozilla1.0
Assignee | ||
Comment 14•22 years ago
|
||
We need testcases for fieldset and listbox.
Assignee | ||
Comment 15•22 years ago
|
||
This tests fieldset (which is a block so it *should* be broken) and listbox (which we probably need to fix). At least it should it it's right. My build is crashing when I open local files, so I can't tell until I attach it.
Assignee | ||
Comment 16•22 years ago
|
||
Well, ok, they're both fine (although the fieldset testcase only thanks to the parser, but that's how it should be). So the patch above should be enough.
Status: REOPENED → ASSIGNED
Attachment #77378 -
Attachment description: patch fixing button (and thus file) and combobox → This patch works fine for me
Comment 17•22 years ago
|
||
Comment on attachment 77378 [details] [diff] [review] patch fixing button (and thus file) and combox This patch works fine for me (Change back patch description, sorry for mistake)
Attachment #77378 -
Attachment description: This patch works fine for me → patch fixing button (and thus file) and combox
Comment 18•22 years ago
|
||
Comment on attachment 77378 [details] [diff] [review] patch fixing button (and thus file) and combox r=rods
Attachment #77378 -
Flags: review+
Comment 19•22 years ago
|
||
Comment on attachment 77378 [details] [diff] [review] patch fixing button (and thus file) and combox sr=waterson
Attachment #77378 -
Flags: superreview+
Comment 20•22 years ago
|
||
Comment on attachment 77378 [details] [diff] [review] patch fixing button (and thus file) and combox a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #77378 -
Flags: approval+
Assignee | ||
Comment 21•22 years ago
|
||
Combobox was just fixed in bug 95826.
Assignee | ||
Comment 22•22 years ago
|
||
Fix checked in 2002-04-06 07:31 PST.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago → 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•