107244 - Input elements not painted when in a SPAN with background-color set

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect, P2)

Description

[Richard Zach]

INPUT elements don't get painted if enclosed in a SPAN which has its
background-color set.  It seems they get painted beneath the background of the SPAN.

I'll attach a testcase.

This breaks a major function of WebCT, a web-based course management system, and
is cited as one of the reasons they currently don't support Mozilla (see
http://www.webct.com/>)

Win 2000, 20011027 build, but also observed with recent Linux builds.

Comment 1

[Richard Zach]

Attachment: Testcase

Comment 2

[Boris Zbarsky [:bzbarsky]]

ccing rods.  This seems like a form controls problem...

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch fixing text input, radio, and checkbox

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

We should check if other controls (combobox, list, file, button, etc.) have this
problem...

Comment 5

[rods (gone)]

Looks right r=rods (I know selects don't have the same problem)

Comment 6

[Chris Waterson]

Sure, sr=waterson.

Why doesn't nsLeafFrame::Paint() just call nsFrame::Paint() itself?

Also, you're inconsistent with constants on the LHS of equality tests (e.g.,
|aWhichLayet == BLAH| vs. |NS_OK == rv|), which is surprising for you, dbaron. ;-)

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I converted my |NS_OK == rv| to |NS_SUCCEEDED(rv)| and filed bug 108310 on the
bogus nsresult return values in GetFrameForPoint and bug 108311 on the weirdness
in nsLeafFrame::Paint.

Comment 8

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Fix checked in 2001-11-02 22:23 PDT.

Comment 9

[Madhur Bhatia]

verified fixed on
win2000 buildID: 2001-11-08-06-trunk
macOS9.1 buildID: 2001-11-08-08-trunk

Comment 10

[Pete Zha]

Attachment: Testcase of button, select and file

select, button and button on file control also have this problem.
Should reopen this bug.

Comment 11

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 77372 [details]
Testcase of button, select and file

Select looks fine to me.

Comment 12

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

... because I have an un-checked-in patch to nsComboboxControlFrame.cpp in my tree.

Comment 13

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch fixing button (and thus file) and combox

Comment 14

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

We need testcases for fieldset and listbox.

Comment 15

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: testcase for fieldset and listbox

This tests fieldset (which is a block so it *should* be broken) and listbox
(which we probably need to fix).  At least it should it it's right.  My build
is crashing when I open local files, so I can't tell until I attach it.

Comment 16

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Well, ok, they're both fine (although the fieldset testcase only thanks to the
parser, but that's how it should be).  So the patch above should be enough.

Comment 17

[Pete Zha]

Comment on attachment 77378 [details] [diff] [review]
patch fixing button (and thus file) and combox

This patch works fine for me
(Change back patch description, sorry for mistake)

Comment 18

[rods (gone)]

Comment on attachment 77378 [details] [diff] [review]
patch fixing button (and thus file) and combox

r=rods

Comment 19

[Chris Waterson]

Comment on attachment 77378 [details] [diff] [review]
patch fixing button (and thus file) and combox

sr=waterson

Comment 20

[Asa Dotzler [:asa]]

Comment on attachment 77378 [details] [diff] [review]
patch fixing button (and thus file) and combox

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 21

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Combobox was just fixed in bug 95826.

Comment 22

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Fix checked in 2002-04-06 07:31 PST.