Closed Bug 1072498 Opened 10 years ago Closed 10 years ago

Make APZ work with e10s on OS X (replace dom.browser_frames.useAsyncPanZoom with layers.async-pan-zoom.enabled)

Categories

(Core :: Panning and Zooming, defect)

Product:
Core
Component:
Panning and Zooming
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla36
Tracking Flags:
Tracking Status
e10s later ---
b2g-v2.2 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(2 files)

Gaia half to remove apz.force-enable
46 bytes, text/x-github-pull-request
fabrice
: review+
alive
: review+
Details | Review
Gecko half to fold dom.browser_frames.useAsyncPanZoom into layers.async-pan-zoom.enabled
2.64 KB, patch
fabrice
: review+
kats
: checkin+
Details | Diff | Splinter Review 
Enable both APZ and e10s (layers.async-pan-zoom.enabled and browser.tabs.remote.autostart prefs set to true). Try panning a page (e.g. planet.mozilla.org). Expected: it pans. Actual: it doesn't pan.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Reopening since this is actually slightly different from what bug 1011833 is intended to accomplish, it seems like.

I investigated why APZ isn't working on Mac nightly (which now has e10s enabled) and it basically boils down to the dom.browser_frames.useAsyncPanZoom not being set. If I flip this pref it works, but really we should get rid of this pref and collapse it into layers.async-pan-zoom.enabled. So I'm going to repurpose this bug for that, which will automagically restore APZ behaviour on mac when layer.async-pan-zoom.enabled is turned on.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Assignee: nobody → bugmail.mozilla

        Attachment #8521642 -
        Flags: review?(fabrice)
Summary: Make APZ work with e10s on OS X → Make APZ work with e10s on OS X (replace dom.browser_frames.useAsyncPanZoom with layers.async-pan-zoom.enabled)

        Attachment #8521644 -
        Flags: review?(fabrice) → review+

    
    

    
  
Comment on attachment 8521642 [details] [review]
Gaia half to remove apz.force-enable

lgtm, but I'd like a system peer to take a look too.

        Attachment #8521642 -
        Flags: review?(fabrice)

        Attachment #8521642 -
        Flags: review?(alive)

        Attachment #8521642 -
        Flags: review+

        Attachment #8521642 -
        Flags: review?(alive) → review+

    
    

    
  
Landed the gecko half. Will wait until that gets merged around before requesting a merge on the gaia PR, otherwise we'll end up in a state where APZ is disabled.

https://hg.mozilla.org/integration/mozilla-inbound/rev/80caf94c011d
Whiteboard: [leave open]

    
    

    
  
checkin-needed to merge gaia PR https://github.com/mozilla-b2g/gaia/pull/26082. Thanks!
Keywords: checkin-needed
Whiteboard: [leave open]

    
    

    
  
https://github.com/mozilla-b2g/gaia/commit/dddc2ec99c375aebd7d939e27064a7bc4953adaa
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago

          status-b2g-v2.2:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla36

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: