1072546 - Case-sensitive checkbox doesn't take effect on initial search

Status: RESOLVED FIXED

(Webtools Graveyard :: DXR, defect)

Description

[Dave Hylands [:dhylands]]

If I enter a URL directly:

http://dxr.mozilla.org/mozilla-central/search?q=Dump

then the page that shows up has "Case-sensitive" checked, but the results are clearly not case-sensitive.

I need to uncheck and recheck in order to get case-sensitive results.

I don't mind which way it shows up, but the checkbox should match the search results.

Comment 1

[Erik Rose [:erik][:erikrose]]

Confirmed; that is silly. Thanks for noticing!

Comment 2

[Jon]

It looks like this issue has been fixed? At least when I visit the provided URL the checkbox matches the results.

Comment 3

[Erik Rose [:erik][:erikrose]]

It depends on the state of your cookies.

Comment 4

[Erik Rose [:erik][:erikrose]]

(Pasting from IRC...)

For this bug, we shouldn't change what the query is actually doing; just make the checkbox match it.
Later, we should come back and expose case-sensitivity more in the URL.
For instance, always have a case=... param in it. We currently insert it on a timer for AJAX searches, just as we currently update the rest of the URL, but we need to make sure it gets in there when the form is submitted with the Return key, even when the checkbox is unchecked.
That way, pasting someone else your search URL always gives them the same results.
I also never meant the case-sensitive box to be permanent. It might be better to ultimately support a "case:yes" param in the query itself, possible with the checkbox still visible as a convenience.
But that'll require more thinking.
(We also have the underlying ability to be case-sensitive on a per-term basis, so there's that to consider whether to expose. Would anyone find that useful, or is it just noise?)

Comment 5

[Sitaram Shelke]

Hello Sir, I would like to work on this if it not assigned to anybody. Looking for my first bug. My email goes by [e-mail] if you need to contact and I am also on IRC by name "sitaram".

Comment 6

[(not currently active) Ted Mielczarek]

(In reply to Erik Rose [:erik][:erikrose] from comment #4)
> (We also have the underlying ability to be case-sensitive on a per-term
> basis, so there's that to consider whether to expose. Would anyone find that
> useful, or is it just noise?)

I think in the absence of an explicit "case" parameter in the URL it might be nice to have a heuristic for this, like if your search term is all lowercase then a case-insensitive search makes sense, but a mixed-case search term probably wants a case-sensitive search.

Comment 7

[Peter Elmers [:new_one]]

(In reply to (on vacation July 18- 25) Ted Mielczarek [:ted.mielczarek] from comment #6)
> I think in the absence of an explicit "case" parameter in the URL it might
> be nice to have a heuristic for this, like if your search term is all
> lowercase then a case-insensitive search makes sense, but a mixed-case
> search term probably wants a case-sensitive search.

I'd like to direct you to bug 1184747. Several people have stated that a feature like that would be nice, so I filed a bug to track it.

Comment 8

[Erik Rose [:erik][:erikrose]]

Commit pushed to master at https://github.com/mozilla/dxr

https://github.com/mozilla/dxr/commit/e57c862b36c96a9c5f049f6db939c7a31ef4431c
Keep results from blanking on scroll. Fixes bug #1212956. Fixes bug #1072546.

The query run by infinite scroll is built from, among other things, the state of the Case-sensitive checkbox. Make sure that's synced up with the case param of the querystring on load.