Closed
Bug 1072575
Opened 10 years ago
Closed 10 years ago
fix date_delta in input api to take arbitrary deltas
Categories
(Input Graveyard :: Code Quality, defect)
Input Graveyard
Code Quality
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: willkg, Assigned: willkg)
Details
(Whiteboard: u=analyzer c=api p=1 s=input.2014q3)
Right now the date_delta field in the Input API get feedback endpoint only accepts values "1d", "7d" and "14d". I did that partially because I didn't know what the helpful use cases were here and didn't have time to spend on fleshing this out. Anyhow, Cheng and others have said that having a limited date_delta like that isn't great. It'd be better if it supported arbitrary day-deltas. This bug covers changing the code so it can parse any "int + 'd'" value.
Assignee | ||
Comment 1•10 years ago
|
||
Grabbing this to do now.
Assignee: nobody → willkg
Status: NEW → ASSIGNED
Whiteboard: u=analyzer c=api p=1 s=input.2014q4 → u=analyzer c=api p=1 s=input.2014q3
Assignee | ||
Comment 2•10 years ago
|
||
In a PR: https://github.com/mozilla/fjord/pull/352
Assignee | ||
Comment 3•10 years ago
|
||
Landed in master: https://github.com/mozilla/fjord/commit/7fd52cdf8775b233de2474b78bc812c3a886c348
Assignee | ||
Comment 4•10 years ago
|
||
Pushed to prod just now.
Assignee | ||
Comment 5•10 years ago
|
||
This should have been closed out in comment #4.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Input → Input Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•