1072607 - Event shim doesn't handle removeEventListener correctly

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: fix-capturing-regression

This was a really stupid bug that I found while debugging the session store tests. It's a regression from bug 1059207. The code there looked like this:

    let listener = (event) => this.handleEvent(useCapture, event);
    if (register) {
      this._childGlobal.addEventListener(eventType, listener, useCapture, true);
    } else {
      this._childGlobal.removeEventListener(eventType, listener, useCapture);
    }

The problem is that we get a new closure for listener each time. The removeEventListener call won't remove anything, since the new closure was never a listener. Bug 1072467 includes a test for this.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8494789 [details] [diff] [review]
fix-capturing-regression

Review of attachment 8494789 [details] [diff] [review]:
-----------------------------------------------------------------

Ouch, sorry for missing that during my review, and good catch.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/70ea9e678878

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/70ea9e678878