1072650 - Fix giant wall of logcat output when connection times out

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Malini Das [:mdas] - Away, not checking bugmail]

We've been seeing giant walls of logcat output when the Marionette connection times out during a test (example: Bug 1056626) when it should just find the most recent 5 errors from logcat. Turns out this happened due to Bug 1050211, so we'll need a work around for now.

Comment 1

[Malini Das [:mdas] - Away, not checking bugmail]

Attachment: workaround

I added a check for "IOError" in case other IO errors are thrown. We should investigate in that case.

This fix should make the sheriffs a little less mad.

Comment 2

[David Burns :automatedtester]

Comment on attachment 8494848 [details] [diff] [review]
workaround

Review of attachment 8494848 [details] [diff] [review]:
-----------------------------------------------------------------

Other than my comment this is good to go

::: testing/marionette/client/marionette/runner/mixins/b2g.py
@@ +74,4 @@
>                  error_re = re.compile(r"""[\s\S]*(exception|error)[\s\S]*""",
>                                        flags=re.IGNORECASE)
>                  logcat = device_manager.getLogcat()
> +                # Due to Bug 1050211 

the dreaded white-space-at-the-end-of-the-line is here... we need to remove it before it spreads!

Comment 3

[Malini Das [:mdas] - Away, not checking bugmail]

thanks! fixed whitespace and pushed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9940643b4eab

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9940643b4eab