1072652 - Update removed-files for the move from Contents/MacOS to Contents/Resources

Status: RESOLVED FIXED

(Thunderbird :: Installer, defect)

Description

[Robert Strong (they/them - no direct email)]

With Mac v2 signing we need to use the Contents/Resources directory and the removed-files.in file only understands the Contents/MacOS directory. To deal with this there are two new defines in packager.mk that point to the Contents/MacOS and the Contents/Resources directory on Mac and are empty for other platforms so it is simple to have one entry in the removed-files.in file that work for all platforms.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch

Hi Josiah, here is the first patch. If you want to just prefix everything with @DIR_MACOS@ that will do the job even for other platforms since it will just be an empty string on other platforms.

Comment 2

[Robert Strong (they/them - no direct email)]

Note: the Thunderbird removed-files.in file can be massively cleaned up similar to bug 649607 for Firefox but that shouldn't hold up getting this landed.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8494858 [details] [diff] [review]
patch

Review of attachment 8494858 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r=Standard8

Comment 4

[Josiah Bruner [:jsbruner]]

https://hg.mozilla.org/comm-central/rev/62ef2b19ad9b

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8494858 [details] [diff] [review]
patch

[Triage Comment]
This already landed on aurora, so post-approving as I'd given ok over irc

https://hg.mozilla.org/releases/comm-aurora/rev/895fc3beeb01

Also approving for beta.

Comment 6

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-beta/rev/5da48515537c