Closed Bug 1072652 Opened 5 years ago Closed 5 years ago

Update removed-files for the move from Contents/MacOS to Contents/Resources

Categories

(Thunderbird :: Installer, defect)

All
macOS
defect
Not set

Tracking

(thunderbird34 fixed, thunderbird35 fixed, thunderbird36 fixed)

RESOLVED FIXED
Thunderbird 36.0
Tracking Status
thunderbird34 --- fixed
thunderbird35 --- fixed
thunderbird36 --- fixed

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

Details

Attachments

(1 file)

With Mac v2 signing we need to use the Contents/Resources directory and the removed-files.in file only understands the Contents/MacOS directory. To deal with this there are two new defines in packager.mk that point to the Contents/MacOS and the Contents/Resources directory on Mac and are empty for other platforms so it is simple to have one entry in the removed-files.in file that work for all platforms.
Attached patch patchSplinter Review
Hi Josiah, here is the first patch. If you want to just prefix everything with @DIR_MACOS@ that will do the job even for other platforms since it will just be an empty string on other platforms.
Attachment #8494858 - Flags: feedback?(josiah)
Note: the Thunderbird removed-files.in file can be massively cleaned up similar to bug 649607 for Firefox but that shouldn't hold up getting this landed.
OS: Windows 8.1 → Mac OS X
Hardware: x86_64 → All
Comment on attachment 8494858 [details] [diff] [review]
patch

Review of attachment 8494858 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r=Standard8
Attachment #8494858 - Flags: feedback?(josiah) → review+
https://hg.mozilla.org/comm-central/rev/62ef2b19ad9b
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Assignee: nobody → robert.strong.bugs
Target Milestone: --- → Thunderbird 36.0
Comment on attachment 8494858 [details] [diff] [review]
patch

[Triage Comment]
This already landed on aurora, so post-approving as I'd given ok over irc

https://hg.mozilla.org/releases/comm-aurora/rev/895fc3beeb01

Also approving for beta.
Attachment #8494858 - Flags: approval-comm-beta+
Attachment #8494858 - Flags: approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.