Change "Submit review" label to "Review completed"

RESOLVED FIXED

Status

developer.mozilla.org
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Janet Swisher, Assigned: zeus)

Tracking

Details

(Whiteboard: [specification][type:change])

(Reporter)

Description

4 years ago
What feature should be changed? Please provide the URL of the feature if possible.
==================================================================================
Change the "Submit review" button label (on articles where review has been requested) to "Review completed".

What problems would this solve?
===============================
To users who are not familiar with the MDN review process, it's not clear whether this button means "Submit FOR review" or "Submit A review". (And "submit" doesn't really make sense for what's going on, anyway. It's just clearing the selected review flags.)

Who would use this?
===================
Article authors and reviewers

What would users see?
=====================
The review sidebar button would be labeled "Review completed"

What would users do? What would happen as a result?
===================================================
Reviewers would use the checkboxes and the button as they do now. Users would be less likely to be confused about what the button means.

Is there anything else we should know?
======================================
This bug is based on an IRC conversation with :wlach.
(Assignee)

Comment 1

4 years ago
Submited Push

I made a pull request and put up a fix. First Bug assigned.

https://github.com/mozilla/kuma/pull/2805


Here is an GIT-HUB - IRC communication: 

3:48 PM → github joined ⇐ habber quit
3:48 PM <github> [kuma] zeusintuivo opened pull request #2805: fix bug 1072657 - Updating review submission button text (master...new-issue-1072657) https://github.com/mozilla/kuma/pull/2805
3:48 PM ← github left (github@moz-p2h.5u0.30.192.IP)

Comment 2

4 years ago
Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/dfa152ae1b988b3c858ec3663b490f56c9744a42
fix bug 1072657 - Updating review submission button text

https://github.com/mozilla/kuma/commit/f7404580f19a146764723a3df83dc793ee6bb9fc
Merge pull request #2805 from zeusintuivo/new-issue-1072657

fix bug 1072657 - Updating review submission button text

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Assignee: nobody → zeus
You need to log in before you can comment on or make changes to this bug.