Closed Bug 1072716 Opened 7 years ago Closed 7 years ago

Update removed-files.in for mac v2 signing

Categories

(Firefox OS Graveyard :: General, defect)

x86_64
macOS
defect
Not set
normal

Tracking

(firefox34 fixed, firefox35 fixed)

RESOLVED FIXED
Tracking Status
firefox34 --- fixed
firefox35 --- fixed

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

Details

Attachments

(1 file)

I don't think this matters to the Mac emulator but since the removed-files.in already has ifdef's for XP_MACOSX it very well might.
Assignee: nobody → robert.strong.bugs
Blocks: 1046906
Status: NEW → ASSIGNED
OS: Windows 8.1 → Mac OS X
Attached patch patchSplinter Review
Dave, is this necessary for b2g?
Attachment #8494919 - Flags: review?(dhylands)
With Mac v2 signing we need to use the Contents/Resources directory and the removed-files.in file only understands the Contents/MacOS directory. To deal with this there are two new defines in packager.mk that point to the Contents/MacOS and the Contents/Resources directory on Mac and are empty for other platforms so it is simple to have one entry in the removed-files.in file that work for all platforms.

Some background in the patch in bug 1059567 and feel free to ask any questions you may have.
Blocks: 1059567
Comment on attachment 8494919 [details] [diff] [review]
patch

Review of attachment 8494919 [details] [diff] [review]:
-----------------------------------------------------------------

I have to admit to completely ignorant of most things Mac.

So I'll punt this to mwu.
Attachment #8494919 - Flags: review?(dhylands) → review?(mwu)
Attachment #8494919 - Flags: review?(mwu) → review+
https://hg.mozilla.org/mozilla-central/rev/28ae112eba8d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Landed on aurora in the Mac V2 signing combined patch in bug 1047584
You need to log in before you can comment on or make changes to this bug.