1072778 - Make |mach dmd| work on Linux

Status: RESOLVED FIXED

(Core :: DMD, defect)

Description

[Nicholas Nethercote [inactive]]

I didn't do a good job of reviewing the |mach dmd| patch, alas.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Make |mach dmd| work on Linux

On Linux, |mach dmd| doesn't work because it doesn't set LD_PRELOAD.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Use '-' instead of '_' in |mach dmd| flags

All the other mach commands use '-' for options, as does DMD itself.

Comment 3

[Eric Rahm [:erahm]]

Comment on attachment 8495046 [details] [diff] [review]
Make |mach dmd| work on Linux

Review of attachment 8495046 [details] [diff] [review]:
-----------------------------------------------------------------

r=me Thanks for testing on linux!

Comment 4

[Eric Rahm [:erahm]]

Comment on attachment 8495047 [details] [diff] [review]
(part 2) - Use '-' instead of '_' in |mach dmd| flags

Review of attachment 8495047 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. Definitely more consistent. I don't think I had a good reason for this other than having the --param_name match the function param_name.

Comment 5

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b8b5d2575b75
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec4aec7b0ad9

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b8b5d2575b75
https://hg.mozilla.org/mozilla-central/rev/ec4aec7b0ad9