1072781 - [Window Management] Get screenshot for homescreen app by new getScreenshot API

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

Now we are always ignoring any getscreenshot request to homescreen because in the past we cannot fetch the transparent background for the mozbrowser iframe.

We should try to implement this because :timdream had completed https://bugzilla.mozilla.org/show_bug.cgi?id=878003

Comment 1

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/browser_mixin.js#L101

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Lemme know if either of you are interested to take.

Comment 3

[Steve Chung [:steveck]]

I'll take a look first in sprint 6

Comment 4

[Steve Chung [:steveck]]

Attachment: Link to github

Hi alive, I simply remove the homescreen checking in app window close handler, since it's the only place that blocks the screenshot for homescreen. Please correct me if any ignorance, thanks.

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8514122 [details] [review]
Link to github

I am sorry if this not clear enough, but the core part of this issue is we should enable PNG format in getScreen browserAPI here:
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/browser_mixin.js#L94

See https://developer.mozilla.org/en-US/docs/Web/API/HTMLIFrameElement.getScreenshot

Comment 6

[Steve Chung [:steveck]]

Comment on attachment 8514122 [details] [review]
Link to github

Applied mime-type for screenshot creation. I move the checking inside the browser-mixing to handle this in more general way, and hop this could handle screenshot properly.

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8514122 [details] [review]
Link to github

r+ with nits, lemme know you have problems.

Comment 8

[Steve Chung [:steveck]]

Thanks!
In master: 995b6794eb984ca5cd13884acab250dd7f4f11db