1072797 - [l10n] Import dialog from Gmail is not localized

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Francesco Lodolo [:flod]]

Gaia-Rev        e835b38c5e820099c26b4b08ac6a6db88adf78b0
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/1735ff2bb23e
Build-ID        20140924160204
Version         35.0a1
Device-Name     flame
FW-Release      4.4.2


Just installed v180, so I wend into Contacts to import my Gmail contacts: I click "Import from Gmail", authorize the app and then everything is displayed in English: wait screen, interface to select contacts, etc.

Not sure if there are relevant changes in the way me manage l10n, it definitely used to work fine a few weeks ago.

Comment 1

[Johan Lorenzo [:jlorenzo]]

I have this issue in Italian, Spanish, and German but not in French.

Gaia-Rev        03d7bcad57ea281869976a9aed0a38849f7c8bc5
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/1735ff2bb23e
Build-ID        20140924160204
Version         35.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20140924.192602
FW-Date         Wed Sep 24 19:26:12 EDT 2014
Bootloader      L1TC10011800

Comment 2

[Johan Lorenzo [:jlorenzo]]

QA Wanted for a branch check with the KK base image.

Comment 3

[Francesco Lodolo [:flod]]

(In reply to Johan Lorenzo [:jlorenzo] from comment #1)
> I have this issue in Italian, Spanish, and German but not in French.

Weird. My only explanation for French working is that we're picking up strings from Gaia instead of /locales.

Comment 4

[Axel Hecht [:Pike]]

Can you give me a particular string and its ID that is showing up in French and not in Italian?

(Possible candidate here could be bug 1022767, manifests vs ini, not because I have good reasons to think it is, just because)

Comment 5

[Francesco Lodolo [:flod]]

This is the first string displayed in English (it's actually in /shared)
http://transvision.mozfr.org/?sourcelocale=en-US&locale=it&repo=gaia&search_type=entities&recherche=shared/facebook/facebook.properties:waitFriends

Note that I'm seeing this on the Gaia I flash on the phone with Italian, to test French I should reflash the original build from pvt.

If I check /system/b2g/webapps/communications.gaiamobile.org/application.zip, the string is correctly localized in locales-obj/it.json

I was thinking more of bug 1052136, but only some pieces landed so far.

Comment 6

[Francesco Lodolo [:flod]]

Out of curiosity I flashed the changeset before that landed in bug 1052136 and I get my localization back.
https://github.com/mozilla-b2g/gaia/commit/e2652d9cd24c8bec5b833a63a54c0a151bfb6ff5

NI Gandalf at this point. I'm not 100% positive that's the culprit since there are a ton of changesets in the middle, but I definitely spotted that bug by looking at
https://github.com/mozilla-b2g/gaia/tree/master/apps/communications/contacts/js

Comment 7

[Axel Hecht [:Pike]]

Attachment: inspector of the imports.html page

I hooked up the import dialog on a recent build, and it seems that the import.html page isn't localized right.

The locales list in the meta tag isn't right.

Smells like the manifest patch.

Comment 8

[Francesco Lodolo [:flod]]

That wouldn't completely explain why it works with changeset from comment 6

Around the same landing I also found bug 1068929, which interestingly enough is about /shared

Comment 9

[Zibi Braniecki [:zbraniecki][:gandalf]]

taking

Comment 10

[Pi Wei Cheng [:piwei] (inactive)]

This issue is NOT reproducible on Flame 2.1 and Flame 2.0.

Observed behavior: The gmail contacts import dialog is localized. Tested in Spanish.

Device: Flame
BuildID: 20140925092639
Gaia: 86905e14c3ff06a0e6952ba635b6066ad2eea6b4
Gecko: e128c7d918de
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame
BuildID: 20140925082640
Gaia: 95a51689acd0488b3ba79abe2423cdcc132fff4a
Gecko: bd67c37ece85
Version: 32.0 (2.0)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 11

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: pull request

this is a regression from manifest patch. I remember thinking about this case when I was working on it, and even Axel asked about it, and at the time I couldn't find a better solution.

Now I found a trivial one.

Basically, shared/pages/import is the only place in our code where we added manifest.webapp outside of root of an app. I thought it was needed because those pages are linked from two apps (communications/contacts and ftu) and they are differently positioned vs. root so I couldn't use relative path.

What was beyond my wildest dreams at the time is that I can link the manifest using absolute path "/manifest.webapp".

This patch uses this latest technology to fix the regression.

Comment 12

[Joshua Mitchell (Inactive)]

striking regression window wanted tag - seems like it isn't needed here - patch is already pending.

Comment 13

[Staś Małolepszy :stas]

Comment on attachment 8495570 [details] [review]
pull request

I like how this looks so obvious now :)  r=me, good catch.

Comment 14

[Zibi Braniecki [:zbraniecki][:gandalf]]

Commit: https://github.com/zbraniecki/gaia/commit/11cb0060dbf3472ca5c0af9fc00c19f8441b9408
Merge: https://github.com/mozilla-b2g/gaia/commit/c7cd440cad7fdc72fea3c1ab0b729f23cf962494

Thanks guys! Apologies for the regression!

Comment 15

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

fixed in master already