1072815 - Multiple locales were missing in Lightning 3.3.1 release

Status: RESOLVED FIXED

(Calendar :: Build Config, defect)

Description

[[e-mail]]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0
Build ID: 20140923175406

Steps to reproduce:

My calendar(Lightning add-on) from 3.3 upgrade to 3.3.1. The Chinese UI is disappear.

I check lightning-zh-TW.jar,calendar-zh-TW.jar ,chrome.manifest can not found those jar files and zh-TW setting when I re-install Lightning plugin 3.3.1 version on MS windows.


Actual results:

 The 3.3.1 version not include calendar-zh-TW.jar, lightning-zh-TW.jar Chinese translation files.


Expected results:

It should be show up Traditional Chinese.

Comment 1

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

Confirmed. The 3.3 release on ftp.mozilla.org does have sk, zh-CN, zh-TW, but these locales are missing in 3.3.1 release on AMO, and Nightly locale builds are still working.

Pike, this should be something related to the building process right?

Comment 2

[Axel Hecht [:Pike]]

I don't know a lot about calendar, moving over to there for investigation.

Comment 3

[Philipp Kewisch [:Fallen][☁️📆]]

I wonder how this happened, I assume its because of the shipped-locales file on comm-esr31. Looks like I need to release 3.3.2.

Comment 4

[Michael Bauer]

Also reporting same for Lithuanian and Gaelic, seems to be a general problem

Comment 5

[Philipp Kewisch [:Fallen][☁️📆]]

Attachment: lightning-win32-332.xpi

Could you try this xpi and see if it works for you? I've copied over all locales from 3.3

Comment 6

[Michael Bauer]

After restart, calendar is still all in English :(

Comment 7

[Philipp Kewisch [:Fallen][☁️📆]]

Michael, gd and lt were not part of Lightning 3.3 either, can you confirm? Is it possible that there was some mixup with the dashboard and signoffs at that time?

Comment 8

[Michael Bauer]

Isn't 3.3 well past the point when we agreed that signoff on Tb would automatically work for Lightning or something? I honestly can't remember, I'm useless with dates and numbers.

Comment 9

[Philipp Kewisch [:Fallen][☁️📆]]

Yes, at times of 3.3 the Thunderbird signoff is the one used for Lightning. I can't say why the locale was not included at that time though. The only way I can do that now is to manually compile calendar-gd.jar and lightning-gd.jar and add them in to 3.3.2. I can see if I can create a script that does it from the repository if you give me changesets that work.

Comment 10

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

(In reply to Philipp Kewisch [:Fallen] from comment #5)
> Created attachment 8541232 [details]
> lightning-win32-332.xpi
> 
> Could you try this xpi and see if it works for you? I've copied over all
> locales from 3.3

zh-TW came back in this build.

Comment 11

[Michael Bauer]

I have no idea how to do a changeset but since the number of users is probably low for this locale, I'm ok waiting for 3.4 assuming it won't be a year or so before it comes out.

Comment 12

[Philipp Kewisch [:Fallen][☁️📆]]

With changeset I mean the version you would sign off on where the locale is green on the dashboard, but for the branch of 3.3.x. Version 3.4 is already in beta, thr next would be Lightning 4.0

Comment 13

[Philipp Kewisch [:Fallen][☁️📆]]

If you have trouble finding that version let me know, I'll try to extract the info from the dashboard and hg repository in the next few days.

Comment 14

[Axel Hecht [:Pike]]

I'd suggest to go through the tagged revisions on http://hg.mozilla.org/releases/l10n/mozilla-release/gd/tags (beta still tags, too)

Comment 15

[Philipp Kewisch [:Fallen][☁️📆]]

Attachment: lightning-win32-332.xpi - v2

So I used the signed-off changeset from https://l10n.mozilla.org/shipping/l10n-changesets?av=tb31 for gd and lt, and both locales were missing strings at the time.

I also tried to go down a few commits in the gd repository, the closest I got to success was changeset 02974f2e1dbf from August 25th, where there are only 4 errors and no missing strings. The same for lt with changeset 3da4e0197337.

I've attached an xpi containing the locales at those changesets, please test.

The proposed release date for Lightning 4.0 is 2015-05-19 per https://wiki.mozilla.org/RapidRelease/Calendar (look for Firefox 38). We need to make sure we find a solution so this can be done with the build system until then. This means making sure the commits occur in the right order. If Thunderbird stuff was pushed first, you need to sign off Thunderbird on the Lightning changeset.

Comment 16

[Michael Bauer]

That worked for me (gd), thanks Philipp.

Comment 17

[Rimas Kudelis [use needinfo to ping]]

Seems to work for lt as well. Can you publish this update on AMO?

Comment 18

[Philipp Kewisch [:Fallen][☁️📆]]

Done, https://addons.mozilla.org/en-US/addon/lightning/versions/3.3.2