Closed Bug 1072945 Opened 10 years ago Closed 10 years ago

Intermittent test_peerConnection_setLocalOfferInHaveRemoteOffer.html | uncaught exception - Error: Peer connection is closed at http://mochi.test:8888/tests/dom/media/tests/mochitest/pc.js:1959

Categories

(Core :: WebRTC, defect)

Product:
Core
Component:
WebRTC
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla35
Tracking Flags:
Tracking Status
firefox33 --- unaffected
firefox34 --- unaffected
firefox35 --- fixed
firefox-esr31 --- unaffected

People

(Reporter: cbook, Assigned: drno)

References

(
URL
)

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

bug_1072945_fix_trickle_ICE_on_closed_PC.patch
1.68 KB, patch
drno
: review+
Details | Diff | Splinter Review 
Ubuntu VM 12.04 mozilla-central opt test mochitest-e10s-3 on 2014-09-25 06:35:54 PDT for push e9e56750ca5b

slave: tst-linux32-spot-214

https://tbpl.mozilla.org/php/getParsedLog.php?id=48864601&tree=Mozilla-Central

06:40:26     INFO -  511 INFO TEST-UNEXPECTED-FAIL | /tests/dom/media/tests/mochitest/test_peerConnection_setLocalOfferInHaveRemoteOffer.html | uncaught exception - Error: Peer connection is closed at http://mochi.test:8888/tests/dom/media/tests/mochitest/pc.js:1959
See Also: → 1073226
This logs late ICE candidates as info messages and discards them. Additionally it removed the callback and empties the candidate queue on close().

Try run: https://tbpl.mozilla.org/?tree=Try&rev=47d2f07217b8
Attachment #8495544 - Flags: review?(docfaraday)
Comment on attachment 8495544 [details] [diff] [review]
bug_1072945_fix_trickle_ICE_on_closed_PC.patch

Review of attachment 8495544 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me.
Attachment #8495544 - Flags: review?(docfaraday) → review+
Comment on attachment 8495544 [details] [diff] [review]
bug_1072945_fix_trickle_ICE_on_closed_PC.patch

Review of attachment 8495544 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/tests/mochitest/pc.js
@@ +1939,5 @@
>      self._remote_ice_candidates.push(candidate);
> +    if (self.signalingstate === 'closed') {
> +      info("Received ICE candidate for closed PeerConnection - discarding");
> +      return;
> +    }

This seems fine,

@@ +2573,5 @@
>      // It might be that a test has already closed the pc. In those cases
>      // we should not fail.
>      try {
> +      this._pc.onicecandidate = null;
> +      this._ice_candidates_to_add = [];

... but this looks like a workaround for Bug 1073226. If we need to land this then I think it needs a comment and a bug to remove again once Bug 1073226 is fixed. If we leave workarounds in our tests then we're not testing the real thing.

@@ +2578,5 @@
>        this._pc.close();
>        info(this + ": Closed connection.");
>      }
>      catch (e) {
>        info(this + ": Failure in closing connection - " + e.message);

In fact, this whole try/catch around close looks like a workaround for the bug that pc.close() isn't idempotent.
I meant to comment on this line:
> +      this._pc.onicecandidate = null;
Addressed jib's concerns.

Carrying forward r+=bwc

Try run: https://tbpl.mozilla.org/?tree=Try&rev=11c2f6722793
Attachment #8495544 - Attachment is obsolete: true
Attachment #8496254 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/fba243684e6a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: