Intermittent test_peerConnection_setLocalOfferInHaveRemoteOffer.html | uncaught exception - Error: Peer connection is closed at http://mochi.test:8888/tests/dom/media/tests/mochitest/pc.js:1959

RESOLVED FIXED in Firefox 35

Status

()

Core
WebRTC
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Tomcat, Assigned: drno)

Tracking

({intermittent-failure})

Trunk
mozilla35
x86
Linux
intermittent-failure
Points:
---

Firefox Tracking Flags

(firefox33 unaffected, firefox34 unaffected, firefox35 fixed, firefox-esr31 unaffected)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
Ubuntu VM 12.04 mozilla-central opt test mochitest-e10s-3 on 2014-09-25 06:35:54 PDT for push e9e56750ca5b

slave: tst-linux32-spot-214

https://tbpl.mozilla.org/php/getParsedLog.php?id=48864601&tree=Mozilla-Central

06:40:26     INFO -  511 INFO TEST-UNEXPECTED-FAIL | /tests/dom/media/tests/mochitest/test_peerConnection_setLocalOfferInHaveRemoteOffer.html | uncaught exception - Error: Peer connection is closed at http://mochi.test:8888/tests/dom/media/tests/mochitest/pc.js:1959
(Assignee)

Updated

3 years ago
See Also: → bug 1073226
(Assignee)

Comment 1

3 years ago
Created attachment 8495544 [details] [diff] [review]
bug_1072945_fix_trickle_ICE_on_closed_PC.patch

This logs late ICE candidates as info messages and discards them. Additionally it removed the callback and empties the candidate queue on close().

Try run: https://tbpl.mozilla.org/?tree=Try&rev=47d2f07217b8
Attachment #8495544 - Flags: review?(docfaraday)

Comment 2

3 years ago
Comment on attachment 8495544 [details] [diff] [review]
bug_1072945_fix_trickle_ICE_on_closed_PC.patch

Review of attachment 8495544 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me.
Attachment #8495544 - Flags: review?(docfaraday) → review+
Comment hidden (Treeherder Robot)
Comment on attachment 8495544 [details] [diff] [review]
bug_1072945_fix_trickle_ICE_on_closed_PC.patch

Review of attachment 8495544 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/tests/mochitest/pc.js
@@ +1939,5 @@
>      self._remote_ice_candidates.push(candidate);
> +    if (self.signalingstate === 'closed') {
> +      info("Received ICE candidate for closed PeerConnection - discarding");
> +      return;
> +    }

This seems fine,

@@ +2573,5 @@
>      // It might be that a test has already closed the pc. In those cases
>      // we should not fail.
>      try {
> +      this._pc.onicecandidate = null;
> +      this._ice_candidates_to_add = [];

... but this looks like a workaround for Bug 1073226. If we need to land this then I think it needs a comment and a bug to remove again once Bug 1073226 is fixed. If we leave workarounds in our tests then we're not testing the real thing.

@@ +2578,5 @@
>        this._pc.close();
>        info(this + ": Closed connection.");
>      }
>      catch (e) {
>        info(this + ": Failure in closing connection - " + e.message);

In fact, this whole try/catch around close looks like a workaround for the bug that pc.close() isn't idempotent.
I meant to comment on this line:
> +      this._pc.onicecandidate = null;
Comment hidden (Treeherder Robot)
(Assignee)

Comment 7

3 years ago
Created attachment 8496254 [details] [diff] [review]
bug_1072945_fix_trickle_ICE_on_closed_PC.patch

Addressed jib's concerns.

Carrying forward r+=bwc

Try run: https://tbpl.mozilla.org/?tree=Try&rev=11c2f6722793
Attachment #8495544 - Attachment is obsolete: true
Attachment #8496254 - Flags: review+
Comment hidden (Treeherder Robot)
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
Comment hidden (Treeherder Robot)
(Reporter)

Comment 10

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/fba243684e6a
Assignee: nobody → drno
Keywords: checkin-needed
(Reporter)

Comment 11

3 years ago
https://hg.mozilla.org/mozilla-central/rev/fba243684e6a
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
status-firefox33: --- → unaffected
status-firefox34: --- → unaffected
status-firefox35: --- → fixed
status-firefox-esr31: --- → unaffected
You need to log in before you can comment on or make changes to this bug.