1073049 - Add a check for search ID

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Certification Suite, defect)

Description

[Jonathan Griffin (:jgriffin)]

We've had a request to add a new test to the cert suite, one that verified the search ID.  The search ID is important because it allows us to generate income from searches performed by B2G.

To test this, we'll need to launch the browser app and then get the return value of this method:

https://github.com/mozilla-b2g/gaia/blob/e3028741ea872fdd199b8866ceef08b8564070d0/apps/browser/js/browser.js#L839

The value should contain this string:

client=mobile-firefoxos&channel=fm:org.mozilla:<OEMID>:official&

..and we should present <OEMID> to the user for verification.  <OEMID> will be in the format described by:

https://mana.mozilla.org/wiki/pages/viewpage.action?pageId=35066199

Comment 1

[Dan Minor [:dminor]]

If I call getUrlFromInput('hello world') on my Flame running a 2.0 User build I get:

    https://www.google.com/search?q=hello world

Is that the expected behaviour for this phone/build?

Comment 2

[Jonathan Griffin (:jgriffin)]

(In reply to Dan Minor [:dminor] from comment #1)
> If I call getUrlFromInput('hello world') on my Flame running a 2.0 User
> build I get:
> 
>     https://www.google.com/search?q=hello world
> 
> Is that the expected behaviour for this phone/build?

Good question, let's ask Wayne.

Comment 3

[Wayne Chang [:wchang]]

It seems expected as is. We request launching partners to concatenate with this code:

getUrlFromInput: function browser_getUrlFromInput(input) {
    var hasScheme = !!(rscheme.exec(input) || [])[0];
     var googleSearchID = "client=mobile-firefoxos&channel=fm:org.mozilla:<OEMID>:official&";
 
    // Not a valid URL, could be a search term
    if (UrlHelper.isNotURL(input) && this.searchEngine.uri) {
      var uri = this.searchEngine.uri.replace('{searchTerms}', input);
        uri = uri.substring(0, 29) + googleSearchID + uri.substring(29); 
      return uri;
    }

Which is likely not present on the flame you tested. 
If the code had been added correctly then the URL string should contain <client=mobile-firefoxos&channel=fm:org.mozilla:<OEMID>:official&>

Comment 4

[Dan Minor [:dminor]]

(In reply to Wayne Chang [:wchang] from comment #3)
> It seems expected as is. We request launching partners to concatenate with
> this code:
> 
> getUrlFromInput: function browser_getUrlFromInput(input) {
>     var hasScheme = !!(rscheme.exec(input) || [])[0];
>      var googleSearchID =
> "client=mobile-firefoxos&channel=fm:org.mozilla:<OEMID>:official&";
>  
>     // Not a valid URL, could be a search term
>     if (UrlHelper.isNotURL(input) && this.searchEngine.uri) {
>       var uri = this.searchEngine.uri.replace('{searchTerms}', input);
>         uri = uri.substring(0, 29) + googleSearchID + uri.substring(29); 
>       return uri;
>     }
> 
> Which is likely not present on the flame you tested. 
> If the code had been added correctly then the URL string should contain
> <client=mobile-firefoxos&channel=fm:org.mozilla:<OEMID>:official&>

Thanks! I wanted to make sure I wasn't missing anything - I'll write the test against the exepcted results.

Comment 5

[Dan Minor [:dminor]]

Pull request here: https://github.com/mozilla-b2g/fxos-certsuite/pull/207