Closed Bug 1073086 Opened 5 years ago Closed 5 years ago

Remove broken snapped region clipping code

Categories

(Core :: Graphics, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Details

Attachments

(1 file)

Here we generate a Rect from integers and then round them to do the snapping.

-      Rect rect(r->x, r->y, r->width, r->height);
-
-      rect.Round();

This accomplishes nothing.

Just rip it out.
Attached patch RemoveSplinter Review
Assignee: nobody → jmuizelaar
Attachment #8495412 - Flags: review?(matt.woodrow)
Attachment #8495412 - Flags: review?(matt.woodrow) → review+
Could you resolve the warnings on errors failure? (I'm about to go into a meeting)
https://treeherder.mozilla.org/ui/logviewer.html#?job_id=2621035&repo=mozilla-inbound

Inbound is closed at the moment for another reason, but you're ok to land with CLOSED TREE.

Thanks :-)
s/on errors/as errors/
Reverted since whilst I would hope |aTarget->GetTransform()| didn't change state, given the name - I unfortunately don't have time to check:
https://tbpl.mozilla.org/php/getParsedLog.php?id=49115106&tree=Mozilla-Inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/8d578891aa89
Yeah, you beat me to fixing it by about 1 minute. Sorry I wasn't on IRC.
https://hg.mozilla.org/mozilla-central/rev/beada1ade8be
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.