1073093 - [mozlog] commandline.py should only add a fmt_option if the associated formatter is in log_formatters

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Andrew Halberstadt [:ahal]]

E.g:
If a program removes --log-foo from the global log_formatters dict, --log-foo-level will still be added to the argument parser.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: mozlog_fmt_options

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8495432 [details] [diff] [review]
mozlog_fmt_options

Review of attachment 8495432 [details] [diff] [review]:
-----------------------------------------------------------------

I don't see any harm in this, but I guess bug 1066643 might account for this.

::: testing/mozbase/mozlog/mozlog/structured/commandline.py
@@ +63,5 @@
>                               help=help_str)
>          for optname, (cls, help_str, formatters) in fmt_options.iteritems():
>              for fmt in formatters:
> +                # make sure fmt wasn't removed from log_formatters
> +                if fmt in log_formatters.keys():

Could be just 'if fmt in log_formatters:'

Comment 3

[Andrew Halberstadt [:ahal]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c6ab97a41edb

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c6ab97a41edb