1073094 - Disable jsloader.reuseGlobal on debug builds

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Michael Wu [:mwu]]

Attachment: Disable jsloader.reuseGlobal on debug builds

This would help catch bugs like bug 1058978.

Comment 1

[Michael Wu [:mwu]]

https://tbpl.mozilla.org/?tree=Try&rev=c132515781ad

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8495414 [details] [diff] [review]
Disable jsloader.reuseGlobal on debug builds

Review of attachment 8495414 [details] [diff] [review]:
-----------------------------------------------------------------

Bad news, this doesn't work.

http://hg.mozilla.org/mozilla-central/annotate/e9e56750ca5b/js/xpconnect/loader/mozJSComponentLoader.cpp#l389

Comment 3

[Michael Wu [:mwu]]

Crap. Well, let's disable it there too.

https://tbpl.mozilla.org/?tree=Try&rev=bdd0dca643c7

Comment 4

[Michael Wu [:mwu]]

https://tbpl.mozilla.org/?tree=Try&rev=0056818fcd7f

Comment 5

[Michael Wu [:mwu]]

Attachment: Disable jsloader.reuseGlobal on debug builds, v2

Looks like ResourceStatsDB.jsm is the only tested JSM remaining that relies on shared scope to work.

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8495977 [details] [diff] [review]
Disable jsloader.reuseGlobal on debug builds, v2

Review of attachment 8495977 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not thrilled about my phone breaking ...

Comment 7

[Michael Wu [:mwu]]

https://hg.mozilla.org/integration/b2g-inbound/rev/8eb61163582b

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8eb61163582b