Closed Bug 1073094 Opened 5 years ago Closed 5 years ago

Disable jsloader.reuseGlobal on debug builds

Categories

(Firefox OS Graveyard :: General, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S6 (10oct)

People

(Reporter: mwu, Assigned: mwu)

Details

Attachments

(1 file, 1 obsolete file)

This would help catch bugs like bug 1058978.
Attachment #8495414 - Flags: review?(khuey)
Comment on attachment 8495414 [details] [diff] [review]
Disable jsloader.reuseGlobal on debug builds

Review of attachment 8495414 [details] [diff] [review]:
-----------------------------------------------------------------

Bad news, this doesn't work.

http://hg.mozilla.org/mozilla-central/annotate/e9e56750ca5b/js/xpconnect/loader/mozJSComponentLoader.cpp#l389
Attachment #8495414 - Flags: review?(khuey) → review-
Crap. Well, let's disable it there too.

https://tbpl.mozilla.org/?tree=Try&rev=bdd0dca643c7
Looks like ResourceStatsDB.jsm is the only tested JSM remaining that relies on shared scope to work.
Attachment #8495414 - Attachment is obsolete: true
Attachment #8495977 - Flags: review?(khuey)
Comment on attachment 8495977 [details] [diff] [review]
Disable jsloader.reuseGlobal on debug builds, v2

Review of attachment 8495977 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not thrilled about my phone breaking ...
Attachment #8495977 - Flags: review?(khuey) → review+
https://hg.mozilla.org/mozilla-central/rev/8eb61163582b
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S6 (10oct)
You need to log in before you can comment on or make changes to this bug.