1073176 - [Dialer][Browser] When user receieves a call while watching a video on the web, the top portion of the call screen will blacked out

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[[:SalvadorR]]

Attachment: blackout.png

Description:
When user plays a video player with the browser app, and watches a video in fullscreen, if user receives a call, the top portion of the entire screen will be blacked out, blocking the taskbar and caller's information.
   
Repro Steps:
1) Update a Flame device to BuildID: 20140925000204
2) Play a Youtube video from the browser app
3) View the video in fullscreen and receive a call from another device
4) Observe the Callscreen
  
Actual: The entire top portion of the screen will be blacked out

Expected: 
The call screen shows properly when receiving a call
  
Environmental Variables:
Device: Flame 2.1(319mb)
BuildID: 20140925000204
Gaia: 8061ab487d42cbc49b329fd68b9ca90e0fe477e6
Gecko: e970bc96f8b5
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
  
Notes: This issue reproed on the following web video players: Youtube, Vimeo and Yahoo
  
Repro frequency: 5/5
See attached: Screenshot, Logcat

Comment 1

[[:SalvadorR]]

This issue also occurs on Flame 2.2

Actual: The entire top portion of the screen will be blacked out

Flame 2.2 KitKat Base (319mb)

Environmental Variables:
Device: Flame 2.2 Master
BuildID: 20140925040206
Gaia: c5d2e2f4ebf5f370d6003517057dcd47493dec90
Gecko: 32acbe1d64dc
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0
----------------------------------------------------------------------
This issue does NOT occur on Flame 2.0

Expected: 
The call screen shows properly when receiving a call

Flame 2.0 KitKat Base (319mb)

Environmental Variables:
Device: Flame 2.0
BuildID: 20140924183011
Gaia: 87ee41fcb3f9a14d7a8bb67f1dd7fd95a6bcd0f0
Gecko: b1cb27078909
Version: 32.0 (2.0)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[[:SalvadorR]]

Attachment: logcat_20140925_1236.txt

Comment 3

[Anthony Ricaud (:rik)]

[Blocking Requested - why for this release]:Prevents the user from knowing who is calling them.

Comment 4

[Anthony Ricaud (:rik)]

I'm guessing this is a regression from bug 927862 but that's just a guess.

Comment 5

[Duane Dixon [:ddixon]]

Unable to provide Regression Window. 

Issue DOES occur in the earliest 2.2 Flame build (v180 base image).  

Device: Flame Master
Build ID: 20140904171737
Gaia: de59e0c3614dd0061881fe284e9f2d74fa0d1d5d
Gecko: 8703c1895505
Version: 35.0a1 (Master)
Firmware Version: v180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Comment 6

[Joshua Mitchell (Inactive)]

Duane - let's see if this repros in JB and we can find a window there with are larger collection of builds

Comment 7

[Duane Dixon [:ddixon]]

B2G Inbound Regression Window

Last Working

Device: Flame 2.1
Build ID: 20140828211200
Gaia: 8d965e7182500fd1849e8eec5ae2aca35a55af22
Gecko: efb4f3f291a4
Version: 34.0a1 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

First Broken

Device: Flame 2.1
Build ID: 20140828223200
Gaia: 6f270b9fee0c1f09863f5e1aa640937a07c7fdae
Gecko: 18ed4643a705
Version: 34.0a1 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Last Working Gaia and First Broken Gecko
Issue DOES NOT occur here. 
Gaia: 8d965e7182500fd1849e8eec5ae2aca35a55af22
Gecko: 18ed4643a705

Last Working Gecko and First Broken Gaia
Issue DOES occur here. 
Gaia: 6f270b9fee0c1f09863f5e1aa640937a07c7fdae
Gecko: efb4f3f291a4

Gaia Pushlog: 
https://github.com/mozilla-b2g/gaia/compare/c0fa9fe2f91ea76191d4e7c58db1dbf2993f76c8...6f270b9fee0c1f09863f5e1aa640937a07c7fdae

Possible Cause: 
Bug 927862 - Implement AttentionWindow

Comment 8

[Joshua Mitchell (Inactive)]

Broken by Bug 927862 ? Can you take a look Alive?

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: Patch for master

Cancel fullscreen when opening attention as previously did.

Comment 10

[howie [:howie]]

Triage: regression, blocking

Comment 11

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/commit/0d1889cc720af5266bc875febb38b09a2ad6f600

Comment 12

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8499378 [details] [review]
Patch for master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 927862 regression
[User impact] if declined: user is not able to see who is calling while there is a fullscreen element
[Testing completed]: green on tbpl
[Risk to taking this patch] (and alternatives if risky): simple/riskless
[String changes made]: no

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/eae8fdf0637289ad45e131266455b0cc322a8764

Comment 14

[Ryan VanderMeulen [:RyanVM]]

BTW, why did this commit land under bug 1073216? Please be more careful in the future?

Comment 15

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #14)
> BTW, why did this commit land under bug 1073216? Please be more careful in
> the future?

Oh my fault, sorry!

Comment 16

[Rachel Pribble [:rpribble]]

VERIFIED FIXED on v2.2.

Results: The call screen shows properly when receiving a call.

Environmental variables:

Device: Flame 2.2 Master
BuildID: 20141011040204 (full flash)
Gaia: 95f580a1522ffd0f09302372b78200dab9b6f322
Gecko: 3f6a51950eb5
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

-----------------------------------------------------------------------

This issue STILL OCCURS on v2.1, slightly different from original report.

Results: The call screen appears properly, but the user is taken back to the homescreen instead of the video with entire top portion of the screen appearing white after the call dismisses. The video url will still be seen at the top of the screen, and the user is able to interact with the homescreen behind the white overlap. Restarting is required to resolve the issue.
*Screenshot attached.

Device: Flame 2.1 KK (319 MB) 
BuildID: 20141011000201 (full flash)
Gaia: f5d4ff60ffed8961f7d0380ada9d0facfdfd56b1
Gecko: d813d79d3eae
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 17

[Rachel Pribble [:rpribble]]

New bug 1081565 created for the continued issue on v2.1

Comment 18

[cnelson]

This issue is verified fixed on Flame 2.1. 

Call screen appears without any issues, and returns to the correct youtube video after the call has ended or is dismissed.

Flame 2.1 

Device: Flame 2.1 KK (319mb) (Full Flash)
BuildID: 20141017001201
Gaia: 1ea74943cfe525c76a074ca1d7de8e51a70f6b98
Gecko: 2befa902ff5c
Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d
Version: 34.0 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0