Closed Bug 1073216 Opened 5 years ago Closed 5 years ago

WebGL - Add strong type support for buffer/VAO bindings and texture min/mag/wrap objects

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: wlitwinczyk, Assigned: wlitwinczyk)

Details

Attachments

(1 file, 1 obsolete file)

One more bug for adding strong type support to existing code. See Bug 1071233
Attached patch more_strong_types_patch (obsolete) — Splinter Review
Attachment #8495527 - Flags: review?(jgilbert)
Comment on attachment 8495527 [details] [diff] [review]
more_strong_types_patch

Review of attachment 8495527 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLShader.h
@@ +7,5 @@
>  #define WEBGLSHADER_H_
>  
>  #include "WebGLObjectModel.h"
>  #include "WebGLUniformInfo.h"
> +#include "WebGLStrongTypes.h"

Why include this if we don't seem to change anything else in this file?
Attachment #8495527 - Flags: review?(jgilbert) → review+
Oops, I think I had a change before (this is a very old patch), which became unnecessary once bjacob added the ability to have left-hand sides of ==/!= be plain GLenums.
r=jgilbert carried forward

Removed unnecessary include.

Try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=48fcc4c7a2fd
Attachment #8495527 - Attachment is obsolete: true
Attachment #8496193 - Flags: review+
Try passes
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/47e245533187
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.