1073216 - WebGL - Add strong type support for buffer/VAO bindings and texture min/mag/wrap objects

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Walter Litwinczyk [:walter]]

One more bug for adding strong type support to existing code. See Bug 1071233

Comment 1

[Walter Litwinczyk [:walter]]

Attachment: more_strong_types_patch

Comment 2

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8495527 [details] [diff] [review]
more_strong_types_patch

Review of attachment 8495527 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLShader.h
@@ +7,5 @@
>  #define WEBGLSHADER_H_
>  
>  #include "WebGLObjectModel.h"
>  #include "WebGLUniformInfo.h"
> +#include "WebGLStrongTypes.h"

Why include this if we don't seem to change anything else in this file?

Comment 3

[Walter Litwinczyk [:walter]]

Oops, I think I had a change before (this is a very old patch), which became unnecessary once bjacob added the ability to have left-hand sides of ==/!= be plain GLenums.

Comment 4

[Walter Litwinczyk [:walter]]

Attachment: more_strong_types_patch

r=jgilbert carried forward

Removed unnecessary include.

Try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=48fcc4c7a2fd

Comment 5

[Walter Litwinczyk [:walter]]

Try passes

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/47e245533187

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/47e245533187