1073363 - Add a GeneralPattern class to Moz2D to solve the problem of writing general pattern creation functions

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Jonathan Watt [:jwatt]]

An alternative to the Init* functions would be to replace them with a function that returns an address for use with the placement operator:

  Pattern* ctorAddr(PatternType aType) {
    MOZ_ASSERT(!mPattern);
    switch (aType) {
    case PatternType::COLOR:
      return mPattern = mColorPattern.addr();
    case PatternType::LINEAR_GRADIENT:
      return mPattern = mLinearGradientPattern.addr();
    case PatternType::RADIAL_GRADIENT:
      return mPattern = mRadialGradientPattern.addr();
    case PatternType::SURFACE:
      return mPattern = mSurfacePattern.addr();
    default:
      MOZ_MAKE_COMPILER_ASSUME_IS_UNREACHABLE("Unexpected pattern type");
  }

Assuming that in the general pattern creation function the GeneralPattern is aPattern, you'd then initialize a pattern like:

  ColorPattern pattern =
     new (aPattern->ctorAddr(PatternType::COLOR) ColorPattern(color);

instead of:

  ColorPattern pattern = aPattern->InitColorPattern(color);

Other than making calling code a bit more verbose, I'm not totally loving that this would mean assigning to mPattern without actually knowing that the ctorAddr caller is calling the [appropriate] ctor.

Comment 3

[Jonathan Watt [:jwatt]]

Attachment: part 1 - Rename gfxContext's GeneralPattern to PatternFromState

Comment 4

[Jonathan Watt [:jwatt]]

Attachment: part 2 - Add a GeneralPattern class to Moz2D

Comment 5

[Jonathan Watt [:jwatt]]

Attachment: part 3 - Convert some Mozilla code to use Moz2D's new GeneralPattern class

Feel free to r- this part, or just r+ the canvas part (not sure the gfxPattern changes are worth it, given that it's going to go away in the short to medium term).

Comment 6

[Jonathan Watt [:jwatt]]

Attachment: part 2 - Add a GeneralPattern class to Moz2D

Put in its own file, as requested on IRC.

Comment 7

[Jonathan Watt [:jwatt]]

Attachment: part 3 - Convert some Mozilla code to use Moz2D's new GeneralPattern class

Comment 8

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/51d7456575e8
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3e489423a76
https://hg.mozilla.org/integration/mozilla-inbound/rev/3255a9151456

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/51d7456575e8
https://hg.mozilla.org/mozilla-central/rev/f3e489423a76
https://hg.mozilla.org/mozilla-central/rev/3255a9151456