Closed Bug 1073371 Opened 8 years ago Closed 8 years ago

[Voicemail] [Notification] 'SIM x' shown when receiving a vm notification and only 1 sim in device

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.0 affected, b2g-v2.1 affected, b2g-v2.2 verified)

Status:
VERIFIED FIXED
Milestone:
2.1 S6 (10oct)
Tracking Flags:
Tracking Status
b2g-v2.0 --- affected
b2g-v2.1 --- affected
b2g-v2.2 --- verified

People

(Reporter: ericcc, Assigned: mancas)

Details

Attachments

(4 files, 1 obsolete file)

Voicemail.png
301.89 KB, image/png
Details
one-sim.png
77.59 KB, image/png
ericcc
: ui-review+
Details
Voicemail notification
46 bytes, text/x-github-pull-request
alive
: review+
Details | Review
v2.2-fixed.png
34.94 KB, image/png
Details
Attached image Voicemail.png — 
### STR
1. Receive a voicemail notification

### Actual
See Voicemail.png
'(SIM 2)' shown before it.
Not happening with missed call or message
No difference if sim is in slot1 or 2

### Version
Gaia-Rev        86905e14c3ff06a0e6952ba635b6066ad2eea6b4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-aurora/rev/572b666c54bd
Build-ID        20140925160208
Version         34.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20140925.192608
FW-Date         Thu Sep 25 19:26:18 EDT 2014
Bootloader      L1TC10011800
QA Whiteboard: [COM=Gaia::System]
Assignee: nobody → b.mcb
Attached file Voicemail notification (obsolete) —
Attachment #8495829 - Flags: review?(timdream)
Attached image one-sim.png —
Attachment #8495830 - Flags: ui-review?(echang)
Attachment #8495830 - Flags: ui-review?(echang) → ui-review+
Comment on attachment 8495829 [details] [review]
Voicemail notification

Sorry for the really late reply. I think :EragonJ should be the better person for this.
Attachment #8495829 - Flags: review?(timdream) → review?(ejchen)
Comment on attachment 8495829 [details] [review]
Voicemail notification

@Mancas,

This patch is for System app, I think it would be better to ask for @Alive's review. (I checked your patch and please remember to fix unit tests)
Attachment #8495829 - Flags: review?(ejchen) → review?(alive)
Comment on attachment 8495829 [details] [review]
Voicemail notification

You need to fix voicemail_test.js as well.
Attachment #8495829 - Flags: review?(alive) → feedback+
Attached file Voicemail notification —
Attachment #8495829 - Attachment is obsolete: true
Attachment #8498748 - Flags: review?(alive)
Attachment #8498748 - Flags: review?(alive) → review+
Keywords: checkin-needed
https://github.com/mozilla-b2g/gaia/commit/f0241c68fb6e4ff4d2117b43c7828b71d87c40b6
Status: NEW → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S6 (10oct)
Okay in v2.2
Gaia-Rev        9050edcda308b65d86577c8ed0eedc5c568d8e44
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/0c8ae792f1c0
Build-ID        20141007160202
Version         35.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141007.191609
FW-Date         Tue Oct  7 19:16:20 EDT 2014
Bootloader      L1TC00011840
status-b2g-v2.2: affected → verified
Attached image v2.2-fixed.png —
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.