1073371 - [Voicemail] [Notification] 'SIM x' shown when receiving a vm notification and only 1 sim in device

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Eric Chang [:ericcc] [:echang]]

Attachment: Voicemail.png

### STR
1. Receive a voicemail notification

### Actual
See Voicemail.png
'(SIM 2)' shown before it.
Not happening with missed call or message
No difference if sim is in slot1 or 2

### Version
Gaia-Rev        86905e14c3ff06a0e6952ba635b6066ad2eea6b4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-aurora/rev/572b666c54bd
Build-ID        20140925160208
Version         34.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20140925.192608
FW-Date         Thu Sep 25 19:26:18 EDT 2014
Bootloader      L1TC10011800

Comment 1

[Manuel Casas Barrado [:mancas]]

Attachment: Voicemail notification

Comment 2

[Manuel Casas Barrado [:mancas]]

Attachment: one-sim.png

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8495829 [details] [review]
Voicemail notification

Sorry for the really late reply. I think :EragonJ should be the better person for this.

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8495829 [details] [review]
Voicemail notification

@Mancas,

This patch is for System app, I think it would be better to ask for @Alive's review. (I checked your patch and please remember to fix unit tests)

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8495829 [details] [review]
Voicemail notification

You need to fix voicemail_test.js as well.

Comment 6

[Manuel Casas Barrado [:mancas]]

Attachment: Voicemail notification

Comment 7

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/f0241c68fb6e4ff4d2117b43c7828b71d87c40b6

Comment 8

[Eric Chang [:ericcc] [:echang]]

Okay in v2.2
Gaia-Rev        9050edcda308b65d86577c8ed0eedc5c568d8e44
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/0c8ae792f1c0
Build-ID        20141007160202
Version         35.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141007.191609
FW-Date         Tue Oct  7 19:16:20 EDT 2014
Bootloader      L1TC00011840

Comment 9

[Eric Chang [:ericcc] [:echang]]

Attachment: v2.2-fixed.png