1073423 - [Calendar]selecting + icon will not choose selected date.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Comment 1

[swathiks115]

Attachment: Selected date.png

Comment 2

[swathiks115]

Attachment: Add event.png

Comment 3

[swathiks115]

Select any date before today's date and click + icon. Start date and End date will always be todays date.
Start date and End date is not taking selected day.

Please refer attached screenshot.

Selected date is 10th Sep
Today's date is 26th Sep
click on + icon 
start date and end date in add event screen is 26th Sep 

Expected result: both start date and end date  should be selected date i.e 10th Sep.

Comment 4

[Miller Medeiros [:millermedeiros]]

Harly, can you confirm what is the expected behavior?

Comment 5

[Harly Hsu[:harly]]

Swathiks, nice catch, I wasn't aware of this behavior. 

Hi Miller, from an UX standpoint, I think the start and end date should always reflect on what date user have selected in month view, regardless of if it is the date before/ after today. Thanks.

Comment 6

[swathiks115]

Attachment: calendar+.patch

This patch will fix this issue.

Please give your feedback on this patch.

Comment 7

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8496679 [details] [diff] [review]
calendar+.patch

change looks good to me, can you update the unit tests as well? - you can run them locally with the script `./bin/gaia-test`, then click the calendar header to select all the calendar tests, and then click "execute".

PS: Github pull requests are easier to review since they execute all the unit/integration tests (to catch any potential regression) and allow us to comment on each individual line.

Thanks!

Comment 8

[swathiks115]

Attachment: Pointer to PR

PR is raised with unit tests. Please review.

Comment 9

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8501539 [details]
Pointer to PR

I added a few comments on the Github pull request. Unit tests are failing because of the changes and it also changed the file "mode" for some reason. Please flag me for ?review when you're done with the updates. Thanks!

Comment 10

[swathiks115]

Hi Miller,

  Can you please test Unit Tests without my changes? Because some Unit tests are failing without my changes.

Thanks!

Comment 11

[Miller Medeiros [:millermedeiros]]

swathiks, the calendar unit tests should be working on latest master. Only tests that are expected to fail are the marionette alarm tests (notifications works on Linux but fails on Mac) and sometimes the month_view_test.js fails on the onswipe test (fixed by running "make clean && make really-clean"). gaia-try blackists known failures, so the treeherder results should be accurate. the patch really introduced a regression on the unit tests.

also need to re-apply the changes over latest master (code structure changed during AMD refactor). sorry about that.

Comment 12

[BMO Automation]

Firefox OS is not being worked on