Closed Bug 1073441 Opened 5 years ago Closed 5 years ago

[mozversion] Include base image version for Flame-KK device

Categories

(Testing :: Mozbase, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla35

People

(Reporter: davehunt, Assigned: davehunt)

References

Details

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1032777 +++

For KitKat builds the base image information is stored differently.

This can be found by running:

  adb shell getprop ro.boot.bootloader
Blocks: 1073021
Attached patch bug1073441.patch (obsolete) — Splinter Review
Assignee: nobody → dave.hunt
Status: NEW → ASSIGNED
Attachment #8496759 - Flags: review?(wlachance)
Comment on attachment 8496759 [details] [diff] [review]
bug1073441.patch

Review of attachment 8496759 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mozbase/mozversion/mozversion/mozversion.py
@@ +231,5 @@
>                      self._info[desired_props[key]] = value
>  
>          if self._info.get('device_id', '').lower() == 'flame':
> +            for prop in ['ro.boot.bootloader', 't2m.sw.version']:
> +                value = dm._runCmd(['shell', 'getprop', prop]).output[0]

Unless there's a good reason not to, we should probably use shellCheckOutput here and not _runCmd, which is undocumented API and subject to change.
Attachment #8496759 - Flags: review?(wlachance) → review+
Carrying r+
Attachment #8496759 - Attachment is obsolete: true
Attachment #8497374 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/1ffb7f0c497f
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.