1073441 - [mozversion] Include base image version for Flame-KK device

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

+++ This bug was initially created as a clone of Bug #1032777 +++

For KitKat builds the base image information is stored differently.

This can be found by running:

  adb shell getprop ro.boot.bootloader

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: bug1073441.patch

Comment 2

[William Lachance (:wlach)]

Comment on attachment 8496759 [details] [diff] [review]
bug1073441.patch

Review of attachment 8496759 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mozbase/mozversion/mozversion/mozversion.py
@@ +231,5 @@
>                      self._info[desired_props[key]] = value
>  
>          if self._info.get('device_id', '').lower() == 'flame':
> +            for prop in ['ro.boot.bootloader', 't2m.sw.version']:
> +                value = dm._runCmd(['shell', 'getprop', prop]).output[0]

Unless there's a good reason not to, we should probably use shellCheckOutput here and not _runCmd, which is undocumented API and subject to change.

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Include the base image version for Flame KK devices. v1.1

Carrying r+

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1ffb7f0c497f

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1ffb7f0c497f