Closed Bug 1073463 Opened 5 years ago Closed 3 years ago

Firefox stops loading older postings on Facebook-sites' "Posts to Page" (element nesting limit reached due to bug)

Categories

(Web Compatibility :: Desktop, defect)

x86_64
Windows 7
defect
Not set

Tracking

(platform-rel +)

RESOLVED FIXED
Tracking Status
platform-rel --- +

People

(Reporter: elbart, Assigned: karlcow)

References

()

Details

(Whiteboard: [country-all] [sitewait][platform-rel-Facebook])

Attachments

(5 files)

- Visit URL
- Click on "Posts to page"
- Make sure that the new panel is focused, and press "End" or "Page Down" and keep it pressed to load older postings

At around August 15, the postings stop showing date and location, and soon after the posts stop appearing completely, and the page looks like the attached image.

In Chrome (fast) and IE11 (slowly) I can load back to postings made in 2013, and probably more.

The problem is reproducible with a build from 2012, so it's not a new issue.
Attached image bug.png
I think this problem seems to be caused by dom nesting level limitation. ( bug 256180 )
And I think this seems to be the site bug.
Component: JavaScript Engine → HTML: Parser
Blocks: 256180
(In reply to Elbart from comment #0)
> Created attachment 8495862 [details]
> facebook_loading_old_posts.png
> 
> - Visit URL
> - Click on "Posts to page"

I see no text that reads "Posts to page" on this page.

> - Make sure that the new panel is focused, and press "End" or "Page Down"
> and keep it pressed to load older postings

However, if I scroll down without clicking anything first, I can scroll all the way to the the first post to this Facebook page.

(In reply to Alice0775 White from comment #1)
> Created attachment 8495912 [details]
> bug.png
> 
> I think this problem seems to be caused by dom nesting level limitation. (
> bug 256180 )

Since there's a script adding stuff incrementally, chances are that Firefox doesn't reach the limit in the parser but in layout. Anyway, the limit won't be going away from the parser as long as layout can't deal.

> And I think this seems to be the site bug.

Very likely.
Component: HTML: Parser → Desktop
Product: Core → Tech Evangelism
Attached image "Posts To Page"
(In reply to Henri Sivonen (:hsivonen) from comment #2)
> (In reply to Elbart from comment #0)
> > Created attachment 8495862 [details]
> > facebook_loading_old_posts.png
> > 
> > - Visit URL
> > - Click on "Posts to page"
> 
> I see no text that reads "Posts to page" on this page.

See attached image.
I do not put this as contactready, as we still do not know what causes the issue.
Whiteboard: [country-all]
Attached image loadingstuck.png
I'm encountering this issue on the latest Beta - 42.0b1   
"More Stories" at the bottom refuse to load and present a animated blank box(loading) without displaying any loaded content.  
It was present on Firefox 41b9 as well.  


Tested out a safe-mode/new profile and it still happens there.  
Also tested out on another browser Opera and things are fine there. So its not a connection/facebook problem.  

I think there a problem with the way firefox pings to facebook. There's no verification system to know if its got the data or not. 
It hangs in limbo

I'm willing to help with more info if someone can guide me on whats needed.
Hey bull500 - do you still see this? I think I haven't had this problem for quite a while.
Flags: needinfo?(bullionareboy)
(In reply to Hallvord R. M. Steen [:hallvors] from comment #6)
> Hey bull500 - do you still see this? I think I haven't had this problem for
> quite a while.

Hey!  

My main issue was this(Solved) - https://bugzilla.mozilla.org/show_bug.cgi?id=1174899  
This was the only other bug that matched some of the troubles. 
I made an early comment here thinking both matched up.
Flags: needinfo?(bullionareboy)
I've tested and this still happens. Seems like an OOM or something?
I've attached a screenshot showing that both in Firefox and Chrome the new elements in the "posts to page" lists are nested deeper and deeper. Firefox's rendering is an artifact of hitting its "max nested elements" limit (at a depth of around 200 elements I think).

We should bring this up with Facebook, it's a bug in their script causing the recursive nesting of new content being added to the page. I have not spent time on finding the exact code but it should not be too hard to locate.

Karl, can you follow up with Facebook?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(kdubost)
Flags: needinfo?(kdubost)
Whiteboard: [country-all] → [country-all] [contactready]
Contacted Facebook today by email
Whiteboard: [country-all] [contactready] → [country-all] [sitewait]
Whiteboard: [country-all] [sitewait] → [country-all] [sitewait][platform-rel-Facebook]
platform-rel: --- → ?
Summary: Firefox stops loading older postings on Facebook-sites' "Posts to Page" → Firefox stops loading older postings on Facebook-sites' "Posts to Page" (element nesting limit reached due to bug)
Karl, assuming this still repros, can you re-ping FB on the ML? Thanks.
Flags: needinfo?(kdubost)
Alice, Does it still happen. I'm under the impression that the layout changed with regards to the screenshots in this issue?
Flags: needinfo?(kdubost) → needinfo?(alice0775)
(In reply to Karl Dubost :karlcow from comment #13)
> Alice, Does it still happen. I'm under the impression that the layout
> changed with regards to the screenshots in this issue?

The STR in comment0 is not available.
However I can reproduce the endless loading spinner and 100% cpu usage. And i can see deeply nested div.


STR
1. login facebook with any id
2. open https://www.facebook.com/UPCAustria
3. click on [VISITOR POSTS >] button at the right side pane
4. Scroll down the Visitor Posts pane and click "See More Stories" link
5. Repeat step.4 several times
Flags: needinfo?(alice0775)
Thanks Alice!
Recontacted facebook about it. :)
Assignee: nobody → kdubost
Status: NEW → ASSIGNED
platform-rel: ? → +
On March 1, we got a reply from Facebook saying
> The fix for this is being rolled out and should be fully 
> out by Wednesday next week. Please let me know if this 
> is still an issue after that.

So this should be fixed by now. Alice, could you check a last time?
Many Thanks.
Flags: needinfo?(alice0775)
(In reply to Karl Dubost :karlcow from comment #16)
> On March 1, we got a reply from Facebook saying
> > The fix for this is being rolled out and should be fully 
> > out by Wednesday next week. Please let me know if this 
> > is still an issue after that.
> 
> So this should be fixed by now. Alice, could you check a last time?
> Many Thanks.

I can verify that the problem is no longer reproduced on Nightly55.0a1.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Flags: needinfo?(alice0775)
Resolution: --- → WORKSFORME
Thanks a lot!
Changing to FIXED. as it was fixed by Facebook team.
Resolution: WORKSFORME → FIXED
Product: Tech Evangelism → Web Compatibility
You need to log in before you can comment on or make changes to this bug.