1073471 - ATT FF Custom Build Remove Yahoo Persona Theme

Status: RESOLVED FIXED

(Release Engineering :: Release Requests, defect)

Description

[abhinavn]

We need to remove the Yahoo Theme from the ATT build configuration.
Does that mean simply getting rid of these lines from the distribution.ini?

lightweightThemes.isThemeSelected=true
lightweightThemes.persisted.footerURL=false
lightweightThemes.persisted.headerURL=false
lightweightThemes.usedThemes="[{\"id\":\"263347\",\"name\":\"Yahoo Persona\",\"headerURL\":\"https://addons.cdn.mozilla.net/user-media/addons/263347/header.png?1383336823\",\"footerURL\":\"https://addons.cdn.mozilla.net/user-media/addons/263347/footer.png?1383336823\",\"textcolor\":\"#000000\",\"accentcolor\":\"#d9e2e7\",\"iconURL\":\"https://addons.cdn.mozilla.net/user-media/addons/263347/preview_small.jpg?1383336823\",\"previewURL\":\"https://addons.cdn.mozilla.net/user-media/addons/263347/preview.jpg?1383336823\",\"author\":\"Yahoo Persona\",\"description\":\"The Yahoo! theme.\",\"updateURL\":\"https://versioncheck.addons.mozilla.org/en-US/themes/update-check/263347\",\"version\":\"1.0\",\"updateDate\":1410470974665,\"installDate\":1410470974665}]"

Comment 1

[abhinavn]

Attachment: repack_config_changes_for_yahoo_att.diff

Here's the proposed patch.

Comment 2

[Shane Caraveo (:mixedpuppy)]

(In reply to abhinavn from comment #1)
> Created attachment 8495886 [details] [diff] [review]
> repack_config_changes_for_yahoo_att.diff
> 
> Here's the proposed patch.

That looks fine for new installs but if this distro is in use, it wont change the theme for existing users.

Comment 3

[Shane Caraveo (:mixedpuppy)]

If this is the patch you want to land let me know.

Comment 4

[abhinavn]

(In reply to Shane Caraveo (:mixedpuppy) from comment #2)
> (In reply to abhinavn from comment #1)
> > Created attachment 8495886 [details] [diff] [review]
> > repack_config_changes_for_yahoo_att.diff
> > 
> > Here's the proposed patch.
> 
> That looks fine for new installs but if this distro is in use, it wont
> change the theme for existing users.

How can we change the theme for existing users?

Comment 5

[abhinavn]

I've been told that it's OK to go ahead even if the patch only applies for new installs.
Could you please land a build with this patch?

Comment 6

[abhinavn]

(In reply to abhinavn from comment #5)
> I've been told that it's OK to go ahead even if the patch only applies for
> new installs.
> Could you please land a build with this patch?

Just to confirm: this will be an FF 33 build, right? We would like an FF 33 build with these configs. Also, we have a ticket (https://bugzilla.mozilla.org/show_bug.cgi?id=1080333) to bump up references to FF 32 in our distribution.ini to FF 33. Those changes should also be a part of the build you're going to spin out.

I've made the changes myself and created this new patch. Do let me know if I've missed out any references to FF 32 that need to be changed, or have made incorrect changes.

Comment 7

[abhinavn]

Attachment: repack_config_changes_for_yahoo_att.diff

Comment 8

[Shane Caraveo (:mixedpuppy)]

https://hg.mozilla.org/build/partner-repacks/rev/38157454e56c

Comment 9

[abhinavn]

Is there a test build I could download?

Comment 10

[Shane Caraveo (:mixedpuppy)]

You can find builds at https://ftp.mozilla.org/pub/mozilla.org/firefox/candidates/ or more specifically for today's build here, https://ftp.mozilla.org/pub/mozilla.org/firefox/candidates/34.0b1-candidates/build1/partner-repacks/