1073480 - [Notifications] Ambient Indicator - Remove count indicator

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Description

[Eric Pang [:epang] UX]

Attachment: [Spec] Ambient_Indicator_Notification(no_counter)_Spec_20140926.jpg

Hi Alberto,

The UX team has decided to remove the notification counter from the ambient indicator.  The decision was made since a lot of people were confused by it and thought it might be broken.

I've attached an updated spec.  Now when the toast goes up the bar fades to #00d3ff.

Please let me know if you have any questions, I'm hoping this can be a quick fix.  Thanks!

Comment 1

[Eric Pang [:epang] UX]

Attachment: [Flow] Ambient_Indicator_Notification_Flow.jpg

Comment 2

[Eric Pang [:epang] UX]

[Blocking Requested - why for this release]:
Based on feedback many people find that the notification counter to look like a broken animation.  It has also caused a lot of confusion, because of this UX and Visual have decided to simplify and remove the counter all together.  It should be a simple update.

Comment 3

[Gregor Wagner [:gwagner]]

If its a big UX improvement and simplify things we probably will uplift but we can't hold the release for this.

Comment 4

[Alberto Pastor [:albertopq]]

Attachment: Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/24818

Comment 5

[Eric Pang [:epang] UX]

Comment on attachment 8500344 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/24818

Looks good, thanks Alberto!

Comment 6

[Eric Pang [:epang] UX]

Comment on attachment 8500344 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/24818

would help if I R+ :)

Comment 7

[Eric Pang [:epang] UX]

Hey Alberto, does this need to be reviewed?  Hope this can happen soon so we can flag for uplift.

Comment 8

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/13b570018496375c7d2cb57881705aac266bad1f

Comment 9

[Alberto Pastor [:albertopq]]

Comment on attachment 8500344 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/24818

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Ambient indicator feature
[User impact] if declined: The user will still see the notifications counter on the ambient indicator. See https://bugzilla.mozilla.org/show_bug.cgi?id=1073480#c2 for more details about why for this release.
[Testing completed]: Removing a feature, so just acommodating the unit tests. Deep UX review.
[Risk to taking this patch] (and alternatives if risky): Low risk, just removing a class (and the javascript that decides it).
[String changes made]: -

Comment 10

[Rob MacDonald [:robmac]]

(In reply to Gregor Wagner [:gwagner] from comment #3)
> If its a big UX improvement and simplify things we probably will uplift but
> we can't hold the release for this.

Hi Gregor...

We had feedback that having the dual band of color in the indicator was confusing people as they thought the animation was "stuck" and the phone wasn't working. That's why ux is pushing to get this one through. Can we still request uplift?

Rob

Comment 11

[Gregor Wagner [:gwagner]]

(In reply to Rob MacDonald [:robmac] from comment #10)
> (In reply to Gregor Wagner [:gwagner] from comment #3)
> > If its a big UX improvement and simplify things we probably will uplift but
> > we can't hold the release for this.
> 
> Hi Gregor...
> 
> We had feedback that having the dual band of color in the indicator was
> confusing people as they thought the animation was "stuck" and the phone
> wasn't working. That's why ux is pushing to get this one through. Can we
> still request uplift?
> 
> Rob

Alberto asked for approval in comment 9.

Comment 12

[Yeojin Chung [:YeojinC]]

This issue is verified on Flame 2.2:

Flame 2.2 Master KK (319mb) (Full Flash)

Device: Flame 2.2 Master  KK (319mb) (Full Flash)
BuildID: 20141012040203
Gaia: 717ad4e8b7fc10ab8248500d00ba5ba0977fa8ab
Gecko: 44168a7af20d
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

The count indicator is removed.
--------------------------------------------
Leaving verifyme keyword for 2.1.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/b2dedf0e88d065d0eff765d4f0122370cd778933

Comment 14

[Yeojin Chung [:YeojinC]]

This issue is verified on Flame 2.1:

Device: Flame 2.1 KK (319mb) (Full Flash)
BuildID: 20141017001201
Gaia: 1ea74943cfe525c76a074ca1d7de8e51a70f6b98
Gecko: 2befa902ff5c
Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d
Version: 34.0 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

The count indicator is removed.