1073498 - Use alert screen prompt when the user is no logged-in and try make a call from contact details (Follow-up of bug 1070860)

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, enhancement)

Description

[Maria Angeles Oteo (:oteo)]

According to the feedback provided by UX team in bug 1070860, when a user (not logged-in Loop) wants to call to another from contact details (inside the Contact application) the prompt screen including the error message should be an alert one (not a confirmation as it's implemented now)

https://bug1070860.bugzilla.mozilla.org/attachment.cgi?id=8492998

With two buttons, one for canceling and one for logging in

Comment 1

[Carmen Jimenez Cabezas]

Attachment: V1 Proposed patch

Comment 2

[Carmen Jimenez Cabezas]

Attachment: screenshot - EN

Comment 3

[Carmen Jimenez Cabezas]

Attachment: screenshot - ES

Comment 4

[Mónica UX/UI]

Comment on attachment 8508289 [details]
screenshot - EN

String: "You need to be logged in to use Firefox Hello"

Thanks.

Comment 5

[Mónica UX/UI]

Comment on attachment 8508291 [details]
screenshot - ES

String: "Tienes que iniciar sesión para acceder a Firefox Hello".

Two buttons below => [Ok] [Iniciar sesión].

Thanks.

Comment 6

[Carmen Jimenez Cabezas]

I've preserved the text which was landed in bug 1070860. I've only added the buttons but, if you think I should changed it I'll do it (sure!),

Comment 7

[Mónica UX/UI]

Yes, please.

And, sorry: "Necesitas iniciar sesión para usar Firefox Hello" in spanish, please :)
Thanks.

Comment 8

[Mónica UX/UI]

(In reply to Mónica UX/UI from comment #7)
> Yes, please.
> 
> And, sorry: "Necesitas iniciar sesión para usar Firefox Hello" in spanish,
> please :)
> Thanks.

Remove [Ok] and add [Cancel] or [Cancelar]
Thanks.

Comment 9

[Carmen Jimenez Cabezas]

Attachment: v2 screenshot - EN

Comment 10

[Carmen Jimenez Cabezas]

Attachment: v2 screenshot - ES

Comment 11

[Carmen Jimenez Cabezas]

The screen at [1] doesn't have a loop header (same as the logout window, actually). Should we add a header to the screen at [1] or are you all right with that screen not having a header?

[1]: https://bug1073498.bugzilla.mozilla.org/attachment.cgi?id=8508580

Comment 12

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8508286 [details] [review]
V1 Proposed patch

The code LGTM, left a few comments on the PR. Nothing crazy, just a few nits here and there. Address them and request review at me again once the UX team gives feedback about the headers thing you asked. Thanks Carmen!

Comment 13

[Mónica UX/UI]

Hi Carmen. 
I think that it's ok the screen without screen.

Comment 14

[Carmen Jimenez Cabezas]

Comment on attachment 8508286 [details] [review]
V1 Proposed patch

I made some of the changes the requested, and answered the rest. Can you take a look again? Thanks!!!

Comment 15

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8508286 [details] [review]
V1 Proposed patch

LGTM. r=me

Thanks for addressing the comments and making clear all the doubts. Did kind of smoke test and It seems it works as expected and nothing gets broken.

Thanks for taking care of it Carmen.

PS. Rebase and land at will please.

Comment 16

[Carmen Jimenez Cabezas]

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/01b9d3fcbc8030077c7fa98a2c24c50a0f0f479a

Comment 17

[Loli (:lolimartinezcr)]

Tested with German,English and Spanish languaje selected.

Flame
user
v2.0
Gecko-05f9775
Gaia-d3e4da3
Loop version: master , dd4862e