Closed
Bug 1073515
Opened 11 years ago
Closed 11 years ago
profile.sh reports incomplete symbols when they contain whitespaces for breakpad
Categories
(Firefox OS Graveyard :: Infrastructure, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S6 (10oct)
People
(Reporter: wcosta, Assigned: wcosta)
References
Details
User Story
When using breakpad symbols and when resolved symbols contain whitespaces, only the first part shows up in the profile files.
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8495985 -
Flags: review?(dhylands)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8495985 [details] [review]
Fix symbol resolution
This looks fine to me, but out of curiosity, what kinds of symbols contain spaces in them?
Attachment #8495985 -
Flags: review?(dhylands) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
(In reply to Dave Hylands [:dhylands] from comment #2)
> Comment on attachment 8495985 [details] [review]
> Fix symbol resolution
>
> This looks fine to me, but out of curiosity, what kinds of symbols contain
> spaces in them?
Some symbols contain parameters info, like "test(int var1, int var2)", and the space between the parameters list were causing trouble.
After thought: I don't really want to throw away source file info, but just use the base name instead of the complete path. I updated the patch according so. Could you please review again?
Flags: needinfo?(dhylands)
|
|
||
Comment 4•11 years ago
|
||
Your source_file will include the :line_number. If that's what you expected, then that's fine.
Flags: needinfo?(dhylands)
|
|
Assignee | |
Comment 5•11 years ago
|
||
(In reply to Dave Hylands [:dhylands] from comment #4)
> Your source_file will include the :line_number. If that's what you expected,
> then that's fine.
Yes, it is. Thanks :)
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 6•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S6 (10oct)
You need to log in
before you can comment on or make changes to this bug.
Description
•