1073524 - Increase our usage of gfxGradientCache

Status: NEW

(Core :: Graphics, defect)

Description

[Jonathan Watt [:jwatt]]

Right now we cache SVG gradient stops by calling gfxPattern::CacheColorStops in nsSVGPaintServerFrame::SetupPaintServer. This means two things:

 * We don't benefit from caching when
   nsSVGPaintServerFrame::GetPaintServerPattern is called directly by
   nsSVGIntegrationUtils::DrawableFromPaintServer or
   SVGTextContextPaint::Paint::GetPattern.

 * We enter junk into the cache when the GetPaintServerPattern() call
   in nsSVGPaintServerFrame::SetupPaintServer returns a pattern that
   is not a gradient pattern.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Jonathan Watt [:jwatt]]

This patch makes us do the caching in nsSVGGradientFrame::GetPaintServerPattern at the point that we actually create the gfxPattern that contains a gradient pattern, and adds DrawTarget arguments to a bunch of functions so that we can feed a DrawTarget through so that gfxPattern::CacheColorStops() can create stops that match the backend type.