If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Reenable cache in preferences for DEBUG build

RESOLVED FIXED in 2.1 S8 (7Nov)

Status

Firefox OS
Gaia::Build
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: julienw, Assigned: julienw)

Tracking

unspecified
2.1 S8 (7Nov)
x86_64
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
rickychien
: review+
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
Some time ago (bug 847566), we disabled HTTP cache for DEBUG build. This was understandable back at the time.

Nowadays it's not needed anymore because httpd.js sends the header "Expires: -1" which basically tells Firefox to always revalidate (it was Bug 939729). However using the cache we can get nice 304 answers instead of downloading everything again.
(Assignee)

Comment 1

3 years ago
Created attachment 8513704 [details] [review]
github PR
Assignee: nobody → felash
(Assignee)

Comment 2

3 years ago
Comment on attachment 8513704 [details] [review]
github PR

Hey Ricky,

this is part of an effort to use caching for unit tests, so that it's running faster.
Next in my list is bug 973873 :)

(I filed the intermittent in bug 1091453, it's likely unrelated to this patch)
Attachment #8513704 - Flags: review?(ricky060709)
Comment on attachment 8513704 [details] [review]
github PR

LGTM. :) r+
Attachment #8513704 - Flags: review?(ricky060709) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://github.com/mozilla-b2g/gaia/commit/69af70c32d0027e02fdd428b28640688052aef77
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S8 (7Nov)
You need to log in before you can comment on or make changes to this bug.