1073631 - Assertion failure: !js::IsInnerObject(obj) when using CPOW Xray waiver around window

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I have a testcase in bug 1072467 that does this:
      is(browser.contentWindow.wrappedJSObject.global, 3, "global available on document");

With the patch in bug 1065811 I'm getting this assertion:

Assertion failure: !js::IsInnerObject(obj), at /home/billm/moz/in1/js/xpconnect/wrappers/WrapperFact
ory.cpp:573
xpc::WrapperFactory::WaiveXrayAndWrap(JSContext*, JS::MutableHandle<JSObject*>) (/home/billm/moz/in1
/js/xpconnect/wrappers/WrapperFactory.cpp:573 (discriminator 1))
mozilla::jsipc::JavaScriptShared::findObjectById(JSContext*, mozilla::jsipc::ObjectId const&) (/home
/billm/moz/in1/js/ipc/JavaScriptShared.cpp:401)
mozilla::jsipc::WrapperAnswer::AnswerInstanceOf(mozilla::jsipc::ObjectId const&, mozilla::jsipc::JSI
ID const&, mozilla::jsipc::ReturnStatus*, bool*) (/home/billm/moz/in1/js/ipc/WrapperAnswer.cpp:594)
mozilla::jsipc::JavaScriptBase<mozilla::jsipc::PJavaScriptChild>::AnswerInstanceOf(unsigned long con
st&, mozilla::jsipc::JSIID const&, mozilla::jsipc::ReturnStatus*, bool*) (/home/billm/moz/in1/js/ipc
/JavaScriptBase.h:108)

Can you help, Bobby? It sounds like maybe we just need to outerize somewhere?

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Also, I need to remember to fix the test in bug 1072467 once this is fixed.

Comment 2

[Bobby Holley (:bholley)]

Yeah, we just need a call to JS_ObjectToOuterObject right before the WaiveXrayAndWrap in JavascriptShared.cpp. r=me on that.

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Unfortunately that seems to trigger a compartment mismatch in test_cpows.xul. I'll try to look into it soon.

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: add-waiver-outerize

I was mistaken about what the problem was here. I think this should work.

Comment 5

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0e314ec744be

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0e314ec744be