1073665 - [Firefox Accounts] Screen breaks at the bottom when typing in the email field and tapping X icon at the same time.

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Yeojin Chung [:YeojinC]]

Attachment: logcat_20140926_BrokenScreen.txt

Description:
On the email field on Firefox Accounts page, when the user taps on the keyboard and selects "X" at the same time, the screen breaks at the bottom. A strip of wallpaper is showing at the bottom of the screen, and it does not go away till the user restarts the phone.
  

Repro Steps:
1) Update a Flame device to BuildID: 20140926000202
2) Go to Settings > Firefox Accounts.
3) Select "Create account or sign in".
4) Type in "Enter your email" field, and select the "X" icon on the upper left corner at the same time.

Actual:
A strip of wallpaper is showing at the bottom of the screen.

Expected: 
The user is returned to the previous screen without any graphic error on the screen.

Note:
This issue also occurs on Firefox Accounts page during FTE.

Environmental Variables:
Device: Flame 2.1
BuildID: 20140926000202
Gaia: 6a6ed9433fce47e76c07fd35bc5952acb108f4c8
Gecko: 7b09a378588c
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
 
Repro frequency: 100%
See attached: logcat, video
http://youtu.be/oeYFNYDb32s

Comment 1

[Yeojin Chung [:YeojinC]]

This issue also reproduces on Flame 2.2:

Flame 2.2 KitKat Base (319mb)

Environmental Variables:
Device: Flame 2.2 Master
BuildID: 20140926040203
Gaia: a06714c555ca7068545f10b4437a16c14cd8e7f5
Gecko: 9e3d649b80a2
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

A strip of wallpaper is showing at the bottom of the screen after typing and tapping "X" at the same time.
======================================
This issue does NOT reproduces on Flame 2.0:

Flame 2.0 KitKat Base (319mb)

Device: Flame 2.0
BuildID: 20140926063008
Gaia: c1aa7829548e65360472c31544dbe2839eaf5be1
Gecko: 5a9f1f402425
Version: 32.0 (2.0)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

The user is returned to the previous screen without any graphic error on the screen.

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

[Blocking Requested - why for this release]:

Kind of a tester bug but if the user happens to do this it will cause this strip of wallpaper to show on all screens. This is a regression so nominating this 2.1?

Comment 3

[howie [:howie]]

Triage: regression, blocking. Hi Alive, can you help to assign this? thanks.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Hi Aus, do you have free cycle to take this one? Should be the problem of layoutManager.

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #4)
> Hi Aus, do you have free cycle to take this one? Should be the problem of
> layoutManager.

It's fine if you don't pick up; I pinged you because I'd like to involve you more in win mgmt bugs.

Comment 6

[Aus Lacroix [:aus]]

Hi Alive! I can totally take a look at this. You should have some news tomorrow morning your time. :) (Hopefully a patch to review as well ;))

Comment 7

[Aus Lacroix [:aus]]

tl;dr -- NO REPRO today on central/master Flame KK build.

I've tried to reproduce this with latest flame kk and was _not_ able to. If someone else could confirm that they are seeing the same results as I that'd be quite helpful.

Comment 8

[Adam Alldredge [:AdamA][Inactive]]

I was able to reproduce this issue on the latest Flame 2.2 Master KK build. I am working on a regression window for it right now. You have to be typing fairly fast and keep typing after the "X" is pressed.

Environmental Variables:
Device: Flame 2.2 Master
BuildID: 20140930061521
Gaia: 77ef35f5429bc3dfe9ca192b9aacc3c0bf8857de
Gecko: 2ae57957e4bb
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Comment 9

[Adam Alldredge [:AdamA][Inactive]]

----------------------------------------------------
B2G-Inbound Regression Window (Shallow Flash)
----------------------------------------------------

Last Working:
Device: Flame 2.1
BuildID: 20140815080913
Gaia: 10f2b4d17369457ad8d6aa53d3ae88d9da161a8f
Gecko: 1d77c5d889e6
Version: 34.0a1 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

First Broken:
Device: Flame 2.1
BuildID: 20140815082214
Gaia: 5ec84bcd85ace7879eabe5b36a7f97529bd073dd
Gecko: 42589bf47bcc
Version: 34.0a1 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Last Working Gaia First Broken Gecko: Issue does NOT reproduce
Gaia: 10f2b4d17369457ad8d6aa53d3ae88d9da161a8f
Gecko: 42589bf47bcc

First Broken Gaia Last Working Gecko: Issue DOES reproduce
Gaia: 5ec84bcd85ace7879eabe5b36a7f97529bd073dd
Gecko: 1d77c5d889e6

Pushlog:
https://github.com/mozilla-b2g/gaia/compare/10f2b4d17369457ad8d6aa53d3ae88d9da161a8f...5ec84bcd85ace7879eabe5b36a7f97529bd073dd

Caused by Bug 1041034 or Bug 1048994

Comment 10

[Joshua Mitchell (Inactive)]

Caused by Bug 1041034 or Bug 1048994

Aus - you are already working on this issue, so I'm not going to NI the patch author at this time.

Comment 11

[howie [:howie]]

Hi Ghislain, are you still working on this? Flag ni to make sure since 2.1 FC is approaching. Thanks!

Comment 12

[Aus Lacroix [:aus]]

Howie, yes I'm working on this. I was unfortunately out on Monday for personal reasons but will be back at it tomorrow.

Comment 13

[Aus Lacroix [:aus]]

:_6a68,

It looks like the change that is responsible for this is mostly from you: https://github.com/mozilla-b2g/gaia/compare/10f2b4d17369457ad8d6aa53d3ae88d9da161a8f...5ec84bcd85ace7879eabe5b36a7f97529bd073dd

The change of class to id without updating any css seems a little suspicious to me but it's also possible that we are not getting the blur event when we're going back to the original screen.

Also showing the logo again when the close button is pressed seems to fix it.

It's also possible to fix it in the LayoutManager I think, but I haven't figured out the best way to do that yet.

Comment 14

[Aus Lacroix [:aus]]

See comment #8. You need to *really* be *typing* and hitting the close button for this to happen.

Comment 15

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Hey aus,

Wow, what a cool bug! ^_^

(In reply to Ghislain Aus Lacroix [:aus] from comment #13)
> :_6a68,
> 
> It looks like the change that is responsible for this is mostly from you:
> https://github.com/mozilla-b2g/gaia/compare/
> 10f2b4d17369457ad8d6aa53d3ae88d9da161a8f...
> 5ec84bcd85ace7879eabe5b36a7f97529bd073dd
> 
> The change of class to id without updating any css seems a little suspicious
> to me but it's also possible that we are not getting the blur event when
> we're going back to the original screen.

I added an id but didn't remove the class, so the styling shouldn't have been affected.

I'm sure this bug was uncovered by the patch for bug 1041034, because that patch toggles visibility of the FF logo when the email field is focused/blurred, which messes with the height of the SystemDialog.

I haven't been able to repro this, despite frantic typing while hitting the 'X', but I've been playing the youtube video in extreme slow motion, and it seems like the sequence of events is:

(btw I'll attach screenshots of the interesting events 5 - 10)

1. email field gets focus
2. logo hidden
3. keyboard shown
4. X is tapped
5. FxA dialog closes, the logo that you see actually belongs to the settings panel, not the fxa dialog. note: the keyboard is still visible. this seems like the first bug.
6. a really weird thing happens: I see an autocorrect or spellcheck field drawn under the keyboard
7. the screen height is recalculated, including the keyboard height but not the autocorrect field height. this seems like a second bug.
8. autocorrect field is hidden
9. keyboard animates away
10. there's a weird gap where that autocorrect field was

So, I'm not sure if the bug is that the keyboard ignores the dialog closing because it was getting tapped, or that the flame doesn't correctly report 2 touch events happening almost-simultaneously, or the dialog resizing itself at the same time it's closing, or maybe something else. But I'm happy to help dig further. Let me know.

Comment 16

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Screenshot of event 5 - FxA panel is closing, but keyboard is still active

Comment 17

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Another screenshot of event 5 - FxA panel is gone, but keyboard is still active

Comment 18

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Screenshot of event 6 - field displayed under the keyboard pushes it up

Comment 19

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Screenshot of event 8 - field under keyboard is hidden

Comment 20

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Screenshot of event 9 - after keyboard hide animation is complete

Comment 21

[Aus Lacroix [:aus]]

I'm having a really hard time reproducing this today on latest 2.1 :(

Comment 22

[Aus Lacroix [:aus]]

We've had tons of fixes to the SHB land recently and from the screenshots from 6a68 and the video from QA it looks like the amount of space that's left unpainted is the size of the SHB.

I haven't been able to repro after another round of attempts so it's likely that an SHB bug fix resolved this issue. I'm trying to track down plausible commits that would explain why exactly it would work now.

Comment 23

[Aus Lacroix [:aus]]

One plausible commit that could have fixed this: https://github.com/mozilla-b2g/gaia/commit/3cb034ab4c884c567d39f1766ead80109bfed254

Comment 24

[Aus Lacroix [:aus]]

And another: https://github.com/mozilla-b2g/gaia/commit/0699081e458cef09334d03383370967f1fdc8a30

Comment 25

[Aus Lacroix [:aus]]

And lastly: https://github.com/mozilla-b2g/gaia/commit/ad7891518de4b1e51680988e3606313d515194a2

I also had sfoster test as well and he could not reproduce the issue today.

I'm going to go ahead and mark this as WFM.