Closed Bug 1073688 Opened 10 years ago Closed 10 years ago

[Gallery] - Handle pick activity when user selects a photo, crop, then mounts USB and deletes photo.

Categories

(Firefox OS Graveyard :: Gaia::Gallery, defect)

x86
macOS
defect
Not set
normal

Tracking

(b2g-v2.0 wontfix, b2g-v2.0M verified, b2g-v2.1 wontfix, b2g-v2.1S wontfix, b2g-v2.2 verified, b2g-master verified)

VERIFIED FIXED
Tracking Status
b2g-v2.0 --- wontfix
b2g-v2.0M --- verified
b2g-v2.1 --- wontfix
b2g-v2.1S --- wontfix
b2g-v2.2 --- verified
b2g-master --- verified

People

(Reporter: pdahiya, Assigned: pdahiya)

References

Details

Attachments

(5 files, 1 obsolete file)

See https://bugzilla.mozilla.org/show_bug.cgi?id=1071727#c14

Handle corner case by taking user back to pick view from crop screen when user selects an image to crop, then deletes the file via USB, and then returns and resumes cropping the deleted image.
Hi Russ
The attached patch is using your original fix for bug 963636. Its fixing the corner case of taking user back to pick view when user selects a photo, crop, then mounts USB and deletes photo.
 
It is calling cleanCrop to reset crop editor when switching to pick view. This removes the crop overlay seen from previous cropped and deleted image. Please review. Thanks!
Attachment #8496305 - Flags: review?(rnicoletti)
Assignee: nobody → pdahiya
Comment on attachment 8496305 [details] [review]
PR with fix of bug 1073688

Looks good, r+
Attachment #8496305 - Flags: review?(rnicoletti) → review+
Thanks Russ for review. Patch landed on master

https://github.com/mozilla-b2g/gaia/commit/686eb08c91dcae834b5aa1f2aa3d3e2085515895
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
blocking-b2g: --- → 2.0M+
Blocks: Woodduck
Hi Kai-Zhen,
Could you help to land this on 2.0M? Thanks!
Flags: needinfo?(kli)
This issue is verified fixed on the latest Nightly Flame 3.0 and 2.2 builds.

Actual results: The user is returned to the image pick screen after deleting in image that was being cropped to add to a contact.

Environmental Variables:
Device: Flame 3.0 KK (Full Flash) (319 MB)
BuildID: 20150306010207
Gaia: 7a91c16bfa348be8b25e09719178efa051512988
Gecko: 0189941a3fd5
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Environmental Variables:
Device: Flame 2.2 KK (Full Flash) (319 MB)
BuildID: 20150306002519
Gaia: eb86137e247224e86d17ed1a0a133b2a318dce3c
Gecko: a04034e239fb
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Keywords: verifyme
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Hi Mike,

    This bug has been failed verified on latest Flame v2.1 and 2.1S. I am not sure whether it already has landed on v2.1. Could you help with this bug?  

Thank you.

See attachments: verify_v2.1&2.1S.MP4
Reproduce rate: 5/5
Note:Can't get log when I unplug USB cable.

Repro STR:
1.Enable USB stroage.
2.Create a new contact and add a photo.
3.On cropping screen,plug in USB cable and delete this image that was being cropped to add to a contact.
4.Plug out USB cable.
**The user returns and resumes cropping the deleted image.  --KO.

Flame 2.1 build:
Build ID               20150309161206
Gaia Revision          a227b67d9ae647cc949ec1ef48ced00c80240025
Gaia Date              2015-03-09 15:56:16
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/a61c9c3dfba7
Gecko Version          34.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150309.200323
Firmware Date          Mon Mar  9 20:03:34 EDT 2015
Bootloader             L1TC000118D0

2.1S 512mb:
Build ID               20150309161206
Gaia Revision          485b69e877429b85d08129ddd1cc2c22fd4806ce
Gaia Date              2015-03-09 03:47:59
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1s/rev/fc6db70a7ea2
Gecko Version          34.0
Device Name            scx15_sp7715ea
Firmware(Release)      4.4.2
Firmware(Incremental)  122
Firmware Date          Thu Feb  5 12:42:58 CST 2015


---------------------------------------------------------------------------------------------------
This bug has been successfully verified on latest Woodduck v2.0. User is returned to the image pick screen after deleting in image that was being cropped to add to a contact.

See attachment: verified_v2.0m.mp4
Reproduce rate: 0/5

Woodduck v2.0:
Build ID               20150310050313
Gaia Revision          0e80bc1c501b1a7733841d724d45530c2897b757
Gaia Date              2015-03-09 06:50:46
Gecko Revision         c77dc549894cf6956ca49cfb22228d5e4d2f9a2f
Gecko Version          32.0
Device Name            jrdhz72_w_ff
Firmware(Release)      4.4.2
Firmware(Incremental)  1425935105
Firmware Date          Tue Mar 10 05:05:25 CST 2015
Flags: needinfo?(mlien)
Hi Shally, I cannot play both of your recorded video normally after downloading, could you help to verify it again.
Besides, the STR is not clearly enough to indicate every stage of steps.
I may need your video to verify it much precise.
Flags: needinfo?(mlien) → needinfo?(lixia)
(In reply to Mike Lien[:mlien] from comment #10)
> Hi Shally, I cannot play both of your recorded video normally after
> downloading, could you help to verify it again.
> Besides, the STR is not clearly enough to indicate every stage of steps.
> I may need your video to verify it much precise.

Hi Mike,

    I will re-upload a new video "v2.1.mp4" and log "logcat_v2.1_1548.txt",please refer,thanks.

Update the STR:
1.Enable USB stroage on device.
2.Tap "+" icon to create a new contact and select an image from Gallery.
3.Plug in USB cable and delete this image on PC that was being cropped to add to a contact.
4.Plug out USB cable and verify device.
**The user returns and resumes cropping the deleted image.  --KO
Flags: needinfo?(lixia) → needinfo?(mlien)
Attached video v2.1.MP4 (obsolete) —
Attachment #8575124 - Attachment is obsolete: true
actually this patch didn't land on v2.1 before, on the date of comment 3, v2.1 is not master
change v2.1 and v2.1S status
Flags: needinfo?(mlien)
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage+][MGSEI-Triage+]
Hi Steven, do you think this should be fixed on v2.1S?
Flags: needinfo?(styang)
ok, let's take it for 2.1S.
blocking-b2g: 2.0M+ → 2.1S+
Flags: needinfo?(styang)
Looks like this never made it to v2.1S. Do we still want it?
Flags: needinfo?(vchen)
Flags: needinfo?(jocheng)
No, no need for 2.1s, thanks
Flags: needinfo?(vchen)
blocking-b2g: 2.1S+ → ---
Flags: needinfo?(jocheng)
 This issue has been verified fixed in 3.0, 2.2, and 2.0m according to Comment 6. Removing the verifyme tag because the remaining branches are labeled as "wontfix".
QA Whiteboard: [QAnalyst-Triage+][MGSEI-Triage+] → [QAnalyst-Triage?][MGSEI-Triage+]
Flags: needinfo?(jmercado)
Keywords: verifyme
QA Whiteboard: [QAnalyst-Triage?][MGSEI-Triage+] → [QAnalyst-Triage+][MGSEI-Triage+]
Flags: needinfo?(jmercado)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: