Closed
Bug 1073732
Opened 10 years ago
Closed 10 years ago
Marionette should return a sessionid that contains a uuid
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla36
People
(Reporter: automatedtester, Assigned: automatedtester)
References
(Blocks 1 open bug, )
Details
Attachments
(2 files, 2 obsolete files)
The WebDriver spec suggests we return a uuid for a session. This will simplify things if we want do things like restarts since we just pass the session back to browser and not care if the actorID changes
Updated•10 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Updated•10 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Assignee | ||
Comment 2•10 years ago
|
||
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8519284 -
Flags: review?(jgriffin)
Assignee | ||
Comment 4•10 years ago
|
||
/r/321 - Bug 1073732: Allow Marionette to have sessions ids that are unique for that session; r=jgriffin
Pull down this commit:
hg pull review -r b18dfc3a745fd304bc7be4649043a7b8f5caa7d1
Comment 5•10 years ago
|
||
https://reviewboard.mozilla.org/r/321/#review117
::: testing/marionette/marionette-server.js
(Diff revision 1)
> + logger.info(this.sessionId);
For clarity, let's log something like "sessionId = " + this.sessionId, rather than just the naked id.
::: testing/marionette/marionette-server.js
(Diff revision 1)
> + if (!this.sessionId){
nit: missing space before {
::: testing/marionette/client/marionette/marionette.py
(Diff revision 1)
> - self.session = self._send_message('newSession', 'value', capabilities=desired_capabilities)
> + self.session = self._send_message('newSession', 'value', capabilities=desired_capabilities, sessionId=session_id)
Can we use the same kwarg both here and _send_message...i.e., session_id rather than sessionId?
::: testing/marionette/client/marionette/tests/unit/test_session.py
(Diff revision 1)
> + caps = self.marionette.start_session(session_id="ILoveCheese")
Yum, cheese!
Assignee | ||
Comment 6•10 years ago
|
||
Attachment #8519952 -
Flags: review?(jgriffin)
Assignee | ||
Comment 7•10 years ago
|
||
/r/367 - Bug 1073732: Allow Marionette to have sessions ids that are unique for that session; r=jgriffin
Pull down this commit:
hg pull review -r 2e05d76d153766e39d508c60211a7a4b0eaabb10
Comment 8•10 years ago
|
||
Updated•10 years ago
|
Attachment #8519952 -
Flags: review?(jgriffin) → review+
Assignee | ||
Comment 9•10 years ago
|
||
Comment 10•10 years ago
|
||
sorry Sir :) had to back this out for test failures like https://treeherder.mozilla.org/ui/logviewer.html#?job_id=3761502&repo=mozilla-inbound
Assignee | ||
Comment 11•10 years ago
|
||
Updated•10 years ago
|
Attachment #8519284 -
Flags: review?(jgriffin)
Comment 12•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Assignee | ||
Comment 13•10 years ago
|
||
Attachment #8519952 -
Attachment is obsolete: true
Attachment #8519284 -
Attachment is obsolete: true
Attachment #8618378 -
Flags: review+
Assignee | ||
Comment 14•10 years ago
|
||
Assignee | ||
Comment 15•10 years ago
|
||
Assignee | ||
Comment 16•10 years ago
|
||
Updated•2 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•