Closed Bug 1073732 Opened 9 years ago Closed 9 years ago

Marionette should return a sessionid that contains a uuid

Categories

(Remote Protocol :: Marionette, defect)

Product:
Remote Protocol
Component:
Marionette
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla36

People

(Reporter: automatedtester, Assigned: automatedtester)

References

(Blocks 1 open bug,
URL
)

Details

Attachments

(2 files, 2 obsolete files)

MozReview Request: Bug 1073732: Allow Marionette to have sessions ids that are unique for that session; r=jgriffin
38 bytes, text/x-review-board-request
jgriffin
: review+
Details
MozReview Request: Bug 1073732: Allow Marionette to have sessions ids that are unique for that session; r=jgriffin
38 bytes, text/x-review-board-request
Details 
The WebDriver spec suggests we return a uuid for a session. This will simplify things if we want do things like restarts since we just pass the session back to browser and not care if the actorID changes
Assignee: nobody → ato
Status: NEW → ASSIGNED
OS: Mac OS X → All
Hardware: x86 → All
taking this to work on as part of restarts
Assignee: ato → dburns
Attached file MozReview Request: bz://1073732/mynick (obsolete) — 

        Attachment #8519284 -
        Flags: review?(jgriffin)

    
    

    
  
/r/321 - Bug 1073732: Allow Marionette to have sessions ids that are unique for that session; r=jgriffin

Pull down this commit:

hg pull review -r b18dfc3a745fd304bc7be4649043a7b8f5caa7d1

    
    

    
  
https://reviewboard.mozilla.org/r/321/#review117

::: testing/marionette/marionette-server.js
(Diff revision 1)
> +      logger.info(this.sessionId);

For clarity, let's log something like "sessionId = " + this.sessionId, rather than just the naked id.

::: testing/marionette/marionette-server.js
(Diff revision 1)
> +    if (!this.sessionId){

nit: missing space before {

::: testing/marionette/client/marionette/marionette.py
(Diff revision 1)
> -        self.session = self._send_message('newSession', 'value', capabilities=desired_capabilities)
> +        self.session = self._send_message('newSession', 'value', capabilities=desired_capabilities, sessionId=session_id)

Can we use the same kwarg both here and _send_message...i.e., session_id rather than sessionId?

::: testing/marionette/client/marionette/tests/unit/test_session.py
(Diff revision 1)
> +        caps = self.marionette.start_session(session_id="ILoveCheese")

Yum, cheese!

    
    

    
  


  

        Attachment #8519952 -
        Flags: review?(jgriffin)

    
    

    
  
/r/367 - Bug 1073732: Allow Marionette to have sessions ids that are unique for that session; r=jgriffin

Pull down this commit:

hg pull review -r 2e05d76d153766e39d508c60211a7a4b0eaabb10

        Attachment #8519952 -
        Flags: review?(jgriffin) → review+

        Attachment #8519284 -
        Flags: review?(jgriffin)

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/181e0dae85b9
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla36

    
    

    
  

        Attachment #8519952 -
        Attachment is obsolete: true

        Attachment #8519284 -
        Attachment is obsolete: true

        Attachment #8618378 -
        Flags: review+

    
    

    
  

    
  
Product: Testing → Remote Protocol

          You need to log in
          before you can comment on or make changes to this bug.