Closed Bug 1073743 Opened 5 years ago Closed 5 years ago

[jsdbg2] js/src/vm/Debugger.cpp and Debugger.h are missing many /* static */ markers

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: jimb, Assigned: jimb)

Details

Attachments

(1 file)

Apologies for the tedium.
Attachment #8496341 - Flags: review?(sphink)
Comment on attachment 8496341 [details] [diff] [review]
Comment all static member functions of js::Debugger.

Review of attachment 8496341 [details] [diff] [review]:
-----------------------------------------------------------------

I found your choice of patch file ordering to be brilliant! I never would have thought of using the ironic "inline header first" approach to subtly suggest that true strength comes from revealing full knowledge of those parts of your core being that are necessary for others to truly take advantage of what you have to offer, even when your header file suggests that you can be fully understood without that knowledge. Indeed, putting the header file last underscores the importance of really engaging with you, in stark contrast to the pedestrian "interface first" approach that is the routine in today's world. Furthermore...

Oh, never mind. LGTM.
Attachment #8496341 - Flags: review?(sphink) → review+
+∞ would r? again

https://hg.mozilla.org/integration/mozilla-inbound/rev/9f0a473895ff
Assignee: nobody → jimb
Flags: in-testsuite-
Target Milestone: --- → mozilla36
https://hg.mozilla.org/mozilla-central/rev/9f0a473895ff
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.