1073750 - SCTP port gets parsed twice

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect)

Description

[Nils Ohlmeier [:drno]]

The port in an application m-line first gets parsed as regular payload type and then as SCTP port again.

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: bug_1073750_fix_sctp_port_parsing.patch

Comment 2

[Ethan Hugg [:ehugg]]

Comment on attachment 8496351 [details] [diff] [review]
bug_1073750_fix_sctp_port_parsing.patch

Review of attachment 8496351 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.  

I noticed when testing this out with this page: http://mozilla.github.io/webrtc-landing/data_test.html 
that it doesn't work like it used to.  Do you see the text messages from each side on this test now?

Comment 3

[Nils Ohlmeier [:drno]]

Apparently the trickle ICE support on the webrtc-landing pages is/was broken. I fixed the data_test.html here: http://nils-ohlmeier.github.io/webrtc-landing/data_test.html
With that fixed page it seems to work for me with and without this patch. Mochitests are passing as well.

Is the fixed page working like expected for you Ethan?

Comment 4

[Nils Ohlmeier [:drno]]

Try run: https://tbpl.mozilla.org/?tree=Try&rev=d649c3e68522

Comment 5

[Ethan Hugg [:ehugg]]

Yes, your fixed page works fine with this patch.  Also with Nightly, Aurora and Release.  Thanks.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8c673a309278

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8c673a309278