Closed Bug 1073750 Opened 9 years ago Closed 9 years ago

SCTP port gets parsed twice

Categories

(Core :: WebRTC: Signaling, defect)

Product:
Core
Component:
WebRTC: Signaling
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla35

People

(Reporter: drno, Assigned: drno)

Details

Attachments

(1 file)

bug_1073750_fix_sctp_port_parsing.patch
2.75 KB, patch
ehugg
: review+
Details | Diff | Splinter Review 
The port in an application m-line first gets parsed as regular payload type and then as SCTP port again.

        Attachment #8496351 -
        Flags: review?(ethanhugg)

    
    

    
  
Comment on attachment 8496351 [details] [diff] [review]
bug_1073750_fix_sctp_port_parsing.patch

Review of attachment 8496351 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.  

I noticed when testing this out with this page: http://mozilla.github.io/webrtc-landing/data_test.html 
that it doesn't work like it used to.  Do you see the text messages from each side on this test now?

        Attachment #8496351 -
        Flags: review?(ethanhugg) → review+

    
    

    
  
Apparently the trickle ICE support on the webrtc-landing pages is/was broken. I fixed the data_test.html here: http://nils-ohlmeier.github.io/webrtc-landing/data_test.html
With that fixed page it seems to work for me with and without this patch. Mochitests are passing as well.

Is the fixed page working like expected for you Ethan?
Flags: needinfo?(ethanhugg)

    
    

    
  
Yes, your fixed page works fine with this patch.  Also with Nightly, Aurora and Release.  Thanks.
Flags: needinfo?(ethanhugg)

    
  
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/8c673a309278
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35

          You need to log in
          before you can comment on or make changes to this bug.