SM(arm) builds are broken on Beta33 and Aurora34

RESOLVED FIXED in Firefox 33

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: RyanVM, Assigned: mjrosenb)

Tracking

Trunk
mozilla35
ARM
Linux
Points:
---

Firefox Tracking Flags

(firefox33 fixed, firefox34 fixed, firefox35 fixed, firefox-esr31 unaffected)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Same error for both. Nah, we don't need to be running these builds on the release branches...

https://tbpl.mozilla.org/php/getParsedLog.php?id=49017324&tree=Try

Linux try leak test spidermonkey_try-arm-sim build on 2014-09-26 17:39:59 PDT for push 7951977b3edf
slave: b-linux64-hp-0001

/builds/slave/try_lx-d_sm-arm-sim-0000000000/src/js/src/jsapi-tests/testJitMoveEmitterCycles.cpp:55:8: error: 'JitCode' does not name a type
/builds/slave/try_lx-d_sm-arm-sim-0000000000/src/js/src/jsapi-tests/testJitMoveEmitterCycles.cpp: In member function 'virtual bool cls_testJitMoveEmitterCycles_simple::run(JS::HandleObject)':
/builds/slave/try_lx-d_sm-arm-sim-0000000000/src/js/src/jsapi-tests/testJitMoveEmitterCycles.cpp:94:46: error: 'linkAndAllocate' was not declared in this scope
/builds/slave/try_lx-d_sm-arm-sim-0000000000/src/js/src/jsapi-tests/testJitMoveEmitterCycles.cpp:70:17: warning: unused variable 'jrt' [-Wunused-variable]
/builds/slave/try_lx-d_sm-arm-sim-0000000000/src/js/src/jsapi-tests/testJitMoveEmitterCycles.cpp: In member function 'virtual bool cls_testJitMoveEmitterCycles_autogen::run(JS::HandleObject)':
/builds/slave/try_lx-d_sm-arm-sim-0000000000/src/js/src/jsapi-tests/testJitMoveEmitterCycles.cpp:174:46: error: 'linkAndAllocate' was not declared in this scope
/builds/slave/try_lx-d_sm-arm-sim-0000000000/src/js/src/jsapi-tests/testJitMoveEmitterCycles.cpp:112:17: warning: unused variable 'jrt' [-Wunused-variable]
/builds/slave/try_lx-d_sm-arm-sim-0000000000/src/js/src/jsapi-tests/testJitMoveEmitterCycles.cpp: In member function 'virtual bool cls_testJitMoveEmitterCycles_autogen2::run(JS::HandleObject)':
/builds/slave/try_lx-d_sm-arm-sim-0000000000/src/js/src/jsapi-tests/testJitMoveEmitterCycles.cpp:283:46: error: 'linkAndAllocate' was not declared in this scope
/builds/slave/try_lx-d_sm-arm-sim-0000000000/src/js/src/jsapi-tests/testJitMoveEmitterCycles.cpp:213:17: warning: unused variable 'jrt' [-Wunused-variable]
/builds/slave/try_lx-d_sm-arm-sim-0000000000/src/js/src/jsapi-tests/testJitMoveEmitterCycles.cpp: In member function 'virtual bool cls_testJitMoveEmitterCycles_autogen3::run(JS::HandleObject)':
/builds/slave/try_lx-d_sm-arm-sim-0000000000/src/js/src/jsapi-tests/testJitMoveEmitterCycles.cpp:397:46: error: 'linkAndAllocate' was not declared in this scope
/builds/slave/try_lx-d_sm-arm-sim-0000000000/src/js/src/jsapi-tests/testJitMoveEmitterCycles.cpp:327:17: warning: unused variable 'jrt' [-Wunused-variable]
(Assignee)

Comment 1

4 years ago
Created attachment 8496388 [details] [diff] [review]
fixBuildFailures-r0.patch

Probably overkill, but this made it build locally.
Attachment #8496388 - Flags: review?(dtc-moz)
Comment on attachment 8496388 [details] [diff] [review]
fixBuildFailures-r0.patch

Review of attachment 8496388 [details] [diff] [review]:
-----------------------------------------------------------------

If the test passes then it looks good.
Attachment #8496388 - Flags: review?(dtc-moz) → review+
(Reporter)

Comment 4

4 years ago
Thanks for the quick fix!

https://hg.mozilla.org/integration/mozilla-inbound/rev/a1fb032b0216
https://hg.mozilla.org/releases/mozilla-aurora/rev/0f1e37627803
https://hg.mozilla.org/releases/mozilla-beta/rev/97feda79279e
Assignee: nobody → mrosenberg
status-firefox33: --- → fixed
status-firefox34: --- → fixed
status-firefox35: --- → fixed
status-firefox-esr31: --- → unaffected
(Reporter)

Comment 5

4 years ago
This is still hitting failures on my Aurora-As-Beta push:

https://tbpl.mozilla.org/php/getParsedLog.php?id=49047199&tree=Try#error0
status-firefox33: fixed → affected
status-firefox34: fixed → affected
status-firefox35: fixed → affected
Keywords: leave-open
(Reporter)

Comment 6

4 years ago
Oh, comment 5 was apparently straight-up bustage on trunk and Aurora. Note that beta is green, though. I've backed out the original patch from inbound. I'll land a follow-up fix on Aurora based on whatever revised patch comes next since the jobs don't run by default there anyway.

https://hg.mozilla.org/integration/mozilla-inbound/rev/deb7b678cc9e
status-firefox33: affected → fixed
Keywords: leave-open
(Assignee)

Comment 7

4 years ago
Sanity check: You don't need any more patches from me, correct?
Flags: needinfo?(ryanvm)
(Reporter)

Comment 8

4 years ago
Trunk and Aurora were both hitting the bustage in comment 5. I had to back it out from inbound as a result. So this bug is only fixed on beta at the moment.
Flags: needinfo?(ryanvm)
(Reporter)

Comment 9

4 years ago
For 34/35, is it as simple as just using ION_CODE instead of JSC::ION_CODE? IIRC, most of the JSC stuff was removed in the 34 timeframe.
(Reporter)

Comment 11

4 years ago
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #10)
> Testing that theory:
> https://tbpl.mozilla.org/?tree=Try&rev=8f66dad49fbb

Indeed :)

https://hg.mozilla.org/integration/mozilla-inbound/rev/76ab08438176
https://hg.mozilla.org/releases/mozilla-aurora/rev/4e0bde619641
status-firefox34: affected → fixed
status-firefox35: affected → fixed
https://hg.mozilla.org/mozilla-central/rev/76ab08438176
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.