107379 - Inconsistent table grouping

Status: VERIFIED FIXED

(Bugzilla :: Query/Bug List, defect, P3)

Description

[xyzzy]

When displaying large (>199 bugs) bug lists, Bugzilla groups 199 bugs into 
the first table, and subsequently groups 200 bugs at a time.

This is pretty minor, but I do notice it, and can fix it.  I also want to change 
the 200 to 100 if there are no objections.  It seems a little more intuitive, 
and since I'm on a slow connection, it would give me feedback sooner.  

Change:

1240         $count++;
1241         if ($count % 200 == 0) {
1242             # Too big tables take too much browser memory...
1243             pnl "</TABLE>$tablestart";
1244         }

to:

         if (($count % 100 == 0) && ($count > 0)) {
             # Too big tables take too much browser memory...
             pnl "</TABLE>$tablestart";
         }
         $count++;

or:

         $count++;
         if (($count % 100 == 1) && ($count > 1)) {
             # Too big tables take too much browser memory...
             pnl "</TABLE>$tablestart";
         }

Yay, I knew I'd contribute code someday!  :P

Comment 1

[xyzzy]

Added patch keyword to get CVS love.

Comment 2

[xyzzy]

Needs review first, though...

Comment 3

[Gervase Markham [:gerv]]

CCing myk, who is templatising buglist.cgi.

Gerv

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Thanks for the contribution!  I have incorporated this code into the templatized
version of buglist.cgi (bug 103778), including the reduction from 200 to 100
bugs per table.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Here is a test case by which the fixing of this bug can be verified:

http://bugzilla.mozilla.org/buglist.cgi?email1=&emailtype1=substring&emailassigned_to1=1&email2=&emailtype2=substring&emailreporter2=1&bugidtype=include&bug_id=&changedin=&votes=&chfieldfrom=&chfieldto=Now&chfieldvalue=&short_desc=&short_desc_type=allwordssubstr&long_desc=&long_desc_type=allwordssubstr&bug_file_loc=&bug_file_loc_type=allwordssubstr&status_whiteboard=&status_whiteboard_type=allwordssubstr&keywords=&keywords_type=anywords&field0-0-0=bug_id&type0-0-0=greaterthan&value0-0-0=1000&field0-1-0=bug_id&type0-1-0=lessthan&value0-1-0=2001&cmdtype=doit&namedcmd=2.12&newqueryname=&order=Reuse+same+sort+as+last+time

Comment 6

[Dave Miller [:justdave]]

We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

Comment 7

[Myk Melez [:myk] [@mykmelez]]

This bug has been fixed by the check-in on bug 103778.

Comment 8

[xyzzy]

verified on tip

Comment 9

[Dave Miller [:justdave]]

fixing incorrect milestones on fixed bugs.