1073790 - Fix browser_webperm.js webapprt chrome test

Status: RESOLVED FIXED

(Firefox Graveyard :: Webapp Runtime, defect, P2)

Description

[Marco Castelluccio [:marco]]

The failure is: "uncaught exception - TypeError: PermissionsTable[realPerm] is undefined at chrome://mochitests/content/webapprtChrome/webapprt/test/chrome/browser_webperm.js:31"

The problem is that PermissionsReverseTable["indexedDB-unlimited"] is undefined.

I don't know what regressed this, the result of a bisect after manually applying the patch from bug 1072798 is:
> The first bad revision is:
> changeset:   202469:cb993c1c20a1
> user:        B2G Bumper Bot <[e-mail]>
> date:        Fri Aug 29 01:11:31 2014 -0700
> summary:     Bumping manifests a=b2g-bump

Comment 1

[Marco Castelluccio [:marco]]

Attachment: Patch

Comment 2

[Marco Castelluccio [:marco]]

Attachment: Patch

The test was still failing with the previous patch.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 8542981 [details] [diff] [review]
Patch

Review of attachment 8542981 [details] [diff] [review]:
-----------------------------------------------------------------

::: webapprt/test/chrome/browser_webperm.js
@@ +48,5 @@
> +    },
> +    {
> +      manifestName: "desktop-notification",
> +      permName: "desktop-notification",
> +    },];

Nit: the value of a trailing comma here is that you won't have to modify the line it's on when adding an item to the array, but putting the closing bracket on the same line means you'll have to alter it anyway, so I would put the closing bracket on the next line.

Comment 4

[Marco Castelluccio [:marco]]

Attachment: Patch

Carrying r+.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/854a6dbbd5e4

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/854a6dbbd5e4