Closed Bug 1073790 Opened 5 years ago Closed 5 years ago

Fix browser_webperm.js webapprt chrome test

Categories

(Firefox Graveyard :: Webapp Runtime, defect, P2)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 37

People

(Reporter: marco, Assigned: marco)

References

Details

Attachments

(1 file, 2 obsolete files)

The failure is: "uncaught exception - TypeError: PermissionsTable[realPerm] is undefined at chrome://mochitests/content/webapprtChrome/webapprt/test/chrome/browser_webperm.js:31"

The problem is that PermissionsReverseTable["indexedDB-unlimited"] is undefined.

I don't know what regressed this, the result of a bisect after manually applying the patch from bug 1072798 is:
> The first bad revision is:
> changeset:   202469:cb993c1c20a1
> user:        B2G Bumper Bot <release+b2gbumper@mozilla.com>
> date:        Fri Aug 29 01:11:31 2014 -0700
> summary:     Bumping manifests a=b2g-bump
Priority: -- → P2
Blocks: 1111077
Attached patch Patch (obsolete) — Splinter Review
Attachment #8542977 - Flags: review?(myk)
Attached patch Patch (obsolete) — Splinter Review
The test was still failing with the previous patch.
Assignee: nobody → mar.castelluccio
Attachment #8542977 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8542977 - Flags: review?(myk)
Attachment #8542981 - Flags: review?(myk)
Comment on attachment 8542981 [details] [diff] [review]
Patch

Review of attachment 8542981 [details] [diff] [review]:
-----------------------------------------------------------------

::: webapprt/test/chrome/browser_webperm.js
@@ +48,5 @@
> +    },
> +    {
> +      manifestName: "desktop-notification",
> +      permName: "desktop-notification",
> +    },];

Nit: the value of a trailing comma here is that you won't have to modify the line it's on when adding an item to the array, but putting the closing bracket on the same line means you'll have to alter it anyway, so I would put the closing bracket on the next line.
Attachment #8542981 - Flags: review?(myk) → review+
Attached patch PatchSplinter Review
Carrying r+.
Attachment #8542981 - Attachment is obsolete: true
Attachment #8544731 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/854a6dbbd5e4
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.