Closed Bug 1073792 Opened 5 years ago Closed 5 years ago

Audio sound pitch is wrong

Categories

(Core :: Audio/Video, defect)

34 Branch
x86_64
Windows 7
defect
Not set

Tracking

()

VERIFIED FIXED
mozilla35
Tracking Status
firefox32 --- unaffected
firefox33 --- unaffected
firefox34 + verified
firefox35 + verified

People

(Reporter: alice0775, Assigned: cpearce)

References

()

Details

(Keywords: regression)

Attachments

(1 file)

[Tracking Requested - why for this release]: regression

Steps To Reproduce:
1. Open http://www.kulturradio.de/_testfolder_fuer_alle/5-1.html
2. Play back Teaser

Actual Results:
Women voice pitch is too low

Actual Results:
Women voice pitch should be normal. IE11 and Chrome work properly
Regression window(m-i)
Good:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b91deae84856
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 ID:20140825183854
Bad:
https://hg.mozilla.org/integration/mozilla-inbound/rev/efe5844c9a5b
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 ID:20140825193622
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=b91deae84856&tochange=efe5844c9a5b

Regressed by:
efe5844c9a5b	Chris Pearce — Bug 1057879 - Enable MP4Reader on Windows. r=kentuckyfriedtakahe
Blocks: 1057879
I've got to admit that I'm unless the issue is with the volume of the woman's voice, I'm not sure what the difference is between the browsers. Chris, Anthony - Alice has wonderfully provided a regression window. Can you please review the problem description and see if you can reproduce the issue?
Flags: needinfo?(cpearce)
Flags: needinfo?(ajones)
(In reply to Lawrence Mandel [:lmandel] from comment #2)
> I've got to admit that I'm unless the issue is with the volume of the
> woman's voice, I'm not sure what the difference is between the browsers.
> Chris, Anthony - Alice has wonderfully provided a regression window. Can you
> please review the problem description and see if you can reproduce the issue?

Basically, it's a speed issue.  It's playing back really really slow -- she sounds like a man with a serious speech impediment.
I can reproduce this bug. We can revert https://hg.mozilla.org/mozilla-central/rev/efe5844c9a5b if we don't get round to fixing this by the time it hits beta.
Flags: needinfo?(cpearce)
Attached patch PatchSplinter Review
Pretty easy fix; the WMF MFT doesn't send us a MF_E_TRANSFORM_STREAM_CHANGE for this file when the first output sample has a different stream type than we asked for. So just re-evaluate the output type whenever there's a discontinuity. This will happen on the first sample output, and when we seek.
Assignee: nobody → cpearce
Status: NEW → ASSIGNED
Attachment #8497118 - Flags: review?(kinetik)
Flags: needinfo?(ajones)
Attachment #8497118 - Flags: review?(kinetik) → review+
Flags: needinfo?(cpearce)
https://hg.mozilla.org/mozilla-central/rev/0f3397b2fff3
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Comment on attachment 8497118 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: bug 1055383, new MP4 playback backend on Windows
[User impact if declined]: Some video files will not play audio
[Describe test coverage new/current, TBPL]: Did not regress existing mochitests..
[Risks and why]: Low risk.
[String/UUID change made/needed]: None.
Attachment #8497118 - Flags: approval-mozilla-aurora?
Flags: needinfo?(cpearce)
Comment on attachment 8497118 [details] [diff] [review]
Patch

Aurora+
Attachment #8497118 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Aurora checkin needed.
Keywords: checkin-needed
QA Whiteboard: [good first verify]
testday-20141107 VERIFIED FIXED
(In reply to Alona from comment #12)
> testday-20141107 VERIFIED FIXED

Alona, on what version was this verified? Was it 34 or 35?
Flags: needinfo?(alenakunik)
version 34.0. I followed the instructions of Testday.
Flags: needinfo?(alenakunik)
QA Whiteboard: [good first verify] → [good first verify][testday-20141107]
Depends on: 1096716
Status: RESOLVED → VERIFIED
Target Milestone: mozilla35 → mozilla34
You need to log in before you can comment on or make changes to this bug.