1073838 - TB build bustage (comm-central): NS_NewStreamLoader and NS_NewChannel

Status: RESOLVED DUPLICATE of bug 1071497

(Thunderbird :: Untriaged, defect)

Description

[ISHIKAWA, Chiaki]

I have refreshed my thunderbird comm-central in almost two months
yesterday due to hardware issues.

Now, I notice there are compilation failures of three files.

comm-central/mailnews/addrbook/src/nsAbContentHandler.cpp
comm-central/mailnews/compose/src/nsURLFetcher.cpp
comm-central/mailnews/imap/src/nsImapProtocol.cpp

They are caused incorrect number mismatched type of of arguments to calls the
following functions: NS_NewStreamLoader() and NS_NewChannel().

I think the very recent change in M-C portion of the tree

Bug 1038756 - Extending LoadInfo and storing LoadInfo on all channels
created through NS_NewChannel 

caused the following compilation error(s).

Please note the call to 
NS_NewStreamLoader( 4 arguments ) in
comm-central/mailnews/addrbook/src/nsAbContentHandler.cpp
does not have matching function because the possible candidates have
either 2 or 11 arguments. Bug 1038756 changed the function signature.

The calls to 
NS_NewChannel( 5 arguments) 
in comm-central/mailnews/compose/src/nsURLFetcher.cpp
and
in comm-central/mailnews/imap/src/nsImapProtocol.cpp
do not match possible candidate 
because
the call has nullptr (of type std::nllptr_t) in the 4th argument
position, and this cannot be matched to nsSecurityFlags (aka unsigned
int) according to GCC error message
[and eventually because the # of arguments do not match. Funny
GCC 4.9.1 seems to check this type equivalence and failed to report
the mismatch # of arguments, but of course, the failure of type
equivalence is enough to fail the compilation then and there.]


In any case, I wonder if someone in the know can shed light on
what changes are necessary here.

I read Bug 1038756, but to be honest, it is mumbo jumbo for a
mortal TB user.

Thank you in advance for people's attention.

--- excerpt from the log

  ...

make[6]: Making `all' in `gendict'
make[5]: Making `all' in `data'
Note: rebuild with "make VERBOSE=1 all-local" to show all compiler parameters.
nsAbContentHandler.cpp
nsImapProtocol.cpp
nsURLFetcher.cpp
/REF-COMM-CENTRAL/comm-central/mailnews/addrbook/src/nsAbContentHandler.cpp: In member function ‘virtual nsresult nsAbContentHandler::HandleContent(const char*, nsIInterfaceRequestor*, nsIRequest*)’:
/REF-COMM-CENTRAL/comm-central/mailnews/addrbook/src/nsAbContentHandler.cpp:116:84: error: no matching function for call to ‘NS_NewStreamLoader(nsGetterAddRefs<nsIStreamLoader>, nsCOMPtr<nsIURI>&, nsAbContentHandler*, nsIInterfaceRequestor*&)’
     rv = NS_NewStreamLoader(getter_AddRefs(streamLoader), uri, this, aWindowContext);
                                                                                    ^
/REF-COMM-CENTRAL/comm-central/mailnews/addrbook/src/nsAbContentHandler.cpp:116:84: note: candidates are:
In file included from /REF-COMM-CENTRAL/comm-central/mailnews/addrbook/src/nsAbContentHandler.cpp:8:0:
../../../dist/include/nsNetUtil.h:800:1: note: nsresult NS_NewStreamLoader(nsIStreamLoader**, nsIStreamLoaderObserver*)
 NS_NewStreamLoader(nsIStreamLoader        **result,
 ^
../../../dist/include/nsNetUtil.h:800:1: note:   candidate expects 2 arguments, 4 provided
../../../dist/include/nsNetUtil.h:854:1: note: nsresult NS_NewStreamLoader(nsIStreamLoader**, nsIURI*, nsIStreamLoaderObserver*, nsINode*, nsSecurityFlags, nsContentPolicyType, nsISupports*, nsILoadGroup*, nsIInterfaceRequestor*, nsLoadFlags, nsIURI*)
 NS_NewStreamLoader(nsIStreamLoader**        outStream,
 ^
../../../dist/include/nsNetUtil.h:854:1: note:   candidate expects 11 arguments, 4 provided
../../../dist/include/nsNetUtil.h:882:1: note: nsresult NS_NewStreamLoader(nsIStreamLoader**, nsIURI*, nsIStreamLoaderObserver*, nsIPrincipal*, nsSecurityFlags, nsContentPolicyType, nsISupports*, nsILoadGroup*, nsIInterfaceRequestor*, nsLoadFlags, nsIURI*)
 NS_NewStreamLoader(nsIStreamLoader**        outStream,
 ^
../../../dist/include/nsNetUtil.h:882:1: note:   candidate expects 11 arguments, 4 provided

In the directory  /REF-OBJ-DIR/objdir-tb3/mailnews/addrbook/src
The following command failed to execute properly:
/usr/bin/ccache /usr/bin/g++-4.9 -fno-builtin-strlen -Wl,--gdb-index -Dfdatasync=fdatasync -DDEBUG=1 -DDEBUG_4GB_CHECK -DUSEHELGRIND=1 -o nsAbContentHandler.o -c -I../../../dist/stl_wrappers -I../../../dist/system_wrappers -include /REF-COMM-CENTRAL/comm-central/mozilla/config/gcc_hidden.h -DMOZ_LDAP_XPCOM -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DMOZ_GLUE_IN_PROGRAM -DOSTYPE="Linux3" -DOSARCH=Linux -DNO_NSPR_10_SUPPORT -I/REF-COMM-CENTRAL/comm-central/mailnews/addrbook/src -I. -I../../../dist/include -I/REF-OBJ-DIR/objdir-tb3/dist/include/nspr -I/REF-OBJ-DIR/objdir-tb3/dist/include/nss -fPIC -DMOZILLA_CLIENT -include ../../../mozilla-config.h -MD -MP -MF .deps/nsAbContentHandler.o.pp -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Werror=int-to-pointer-cast -Werror=type-limits -Wempty-body -Wsign-compare -Wno-invalid-offsetof -Wcast-align -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -pipe -DDEBUG -DTRACING -gsplit-dwarf -g -O2 -freorder-blocks -fno-omit-frame-pointer /REF-COMM-CENTRAL/comm-central/mailnews/addrbook/src/nsAbContentHandler.cpp
/REF-COMM-CENTRAL/comm-central/config/rules.mk:966: recipe for target 'nsAbContentHandler.o' failed
make[4]: *** [nsAbContentHandler.o] Error 1
make[4]: Target 'target' not remade because of errors.
/REF-COMM-CENTRAL/comm-central/mozilla/config/recurse.mk:82: recipe for target 'mailnews/addrbook/src/target' failed
make[3]: *** [mailnews/addrbook/src/target] Error 2
/REF-COMM-CENTRAL/comm-central/mailnews/compose/src/nsURLFetcher.cpp: In member function ‘virtual nsresult nsURLFetcher::FireURLRequest(nsIURI*, nsIFile*, nsIOutputStream*, nsAttachSaveCompletionCallback, nsMsgAttachmentHandler*)’:
/REF-COMM-CENTRAL/comm-central/mailnews/compose/src/nsURLFetcher.cpp:320:91: error: no matching function for call to ‘NS_NewChannel(nsGetterAddRefs<nsIChannel>, nsIURI*&, std::nullptr_t, std::nullptr_t, nsURLFetcher*)’
   NS_ENSURE_SUCCESS(NS_NewChannel(getter_AddRefs(channel), aURL, nullptr, nullptr, this), NS_ERROR_FAILURE);
                                                                                           ^
/REF-COMM-CENTRAL/comm-central/mailnews/compose/src/nsURLFetcher.cpp:320:91: note: candidates are:
In file included from /REF-COMM-CENTRAL/comm-central/mailnews/compose/src/nsURLFetcher.cpp:20:0:
../../../dist/include/nsNetUtil.h:293:1: note: nsresult NS_NewChannel(nsIChannel**, nsIURI*, nsINode*, nsSecurityFlags, nsContentPolicyType, nsIChannelPolicy*, nsILoadGroup*, nsIInterfaceRequestor*, nsLoadFlags, nsIIOService*)
 NS_NewChannel(nsIChannel**           outChannel,
 ^
../../../dist/include/nsNetUtil.h:293:1: note:   no known conversion for argument 4 from ‘std::nullptr_t’ to ‘nsSecurityFlags {aka unsigned int}’
../../../dist/include/nsNetUtil.h:319:1: note: nsresult NS_NewChannel(nsIChannel**, nsIURI*, nsIPrincipal*, nsSecurityFlags, nsContentPolicyType, nsIChannelPolicy*, nsILoadGroup*, nsIInterfaceRequestor*, nsLoadFlags, nsIIOService*)
 NS_NewChannel(nsIChannel**           outChannel,
 ^
../../../dist/include/nsNetUtil.h:319:1: note:   no known conversion for argument 4 from ‘std::nullptr_t’ to ‘nsSecurityFlags {aka unsigned int}’

In the directory  /REF-OBJ-DIR/objdir-tb3/mailnews/compose/src
The following command failed to execute properly:
/usr/bin/ccache /usr/bin/g++-4.9 -fno-builtin-strlen -Wl,--gdb-index -Dfdatasync=fdatasync -DDEBUG=1 -DDEBUG_4GB_CHECK -DUSEHELGRIND=1 -o nsURLFetcher.o -c -I../../../dist/stl_wrappers -I../../../dist/system_wrappers -include /REF-COMM-CENTRAL/comm-central/mozilla/config/gcc_hidden.h -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DMOZ_GLUE_IN_PROGRAM -DOSTYPE="Linux3" -DOSARCH=Linux -DNO_NSPR_10_SUPPORT -I/REF-COMM-CENTRAL/comm-central/mailnews/compose/src -I. -I../../../dist/include -I/REF-OBJ-DIR/objdir-tb3/dist/include/nspr -I/REF-OBJ-DIR/objdir-tb3/dist/include/nss -fPIC -DMOZILLA_CLIENT -include ../../../mozilla-config.h -MD -MP -MF .deps/nsURLFetcher.o.pp -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Werror=int-to-pointer-cast -Werror=type-limits -Wempty-body -Wsign-compare -Wno-invalid-offsetof -Wcast-align -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -pipe -DDEBUG -DTRACING -gsplit-dwarf -g -O2 -freorder-blocks -fno-omit-frame-pointer /REF-COMM-CENTRAL/comm-central/mailnews/compose/src/nsURLFetcher.cpp
/REF-COMM-CENTRAL/comm-central/config/rules.mk:966: recipe for target 'nsURLFetcher.o' failed
make[4]: *** [nsURLFetcher.o] Error 1
make[4]: Target 'target' not remade because of errors.
/REF-COMM-CENTRAL/comm-central/mozilla/config/recurse.mk:82: recipe for target 'mailnews/compose/src/target' failed
make[3]: *** [mailnews/compose/src/target] Error 2
/REF-COMM-CENTRAL/comm-central/mailnews/imap/src/nsImapProtocol.cpp: In member function ‘nsresult nsImapProtocol::SetupWithUrl(nsIURI*, nsISupports*)’:
/REF-COMM-CENTRAL/comm-central/mailnews/imap/src/nsImapProtocol.cpp:721:85: error: no matching function for call to ‘NS_NewChannel(nsGetterAddRefs<nsIChannel>, nsIURI*&, std::nullptr_t, std::nullptr_t, std::nullptr_t, int)’
       rv = NS_NewChannel(getter_AddRefs(channel), aURL, nullptr, nullptr, nullptr, 0);
                                                                                     ^
/REF-COMM-CENTRAL/comm-central/mailnews/imap/src/nsImapProtocol.cpp:721:85: note: candidates are:
In file included from /REF-COMM-CENTRAL/comm-central/mailnews/imap/src/nsImapProtocol.cpp:37:0:
../../../dist/include/nsNetUtil.h:293:1: note: nsresult NS_NewChannel(nsIChannel**, nsIURI*, nsINode*, nsSecurityFlags, nsContentPolicyType, nsIChannelPolicy*, nsILoadGroup*, nsIInterfaceRequestor*, nsLoadFlags, nsIIOService*)
 NS_NewChannel(nsIChannel**           outChannel,
 ^
../../../dist/include/nsNetUtil.h:293:1: note:   no known conversion for argument 4 from ‘std::nullptr_t’ to ‘nsSecurityFlags {aka unsigned int}’
../../../dist/include/nsNetUtil.h:319:1: note: nsresult NS_NewChannel(nsIChannel**, nsIURI*, nsIPrincipal*, nsSecurityFlags, nsContentPolicyType, nsIChannelPolicy*, nsILoadGroup*, nsIInterfaceRequestor*, nsLoadFlags, nsIIOService*)
 NS_NewChannel(nsIChannel**           outChannel,
 ^
../../../dist/include/nsNetUtil.h:319:1: note:   no known conversion for argument 4 from ‘std::nullptr_t’ to ‘nsSecurityFlags {aka unsigned int}’

In the directory  /REF-OBJ-DIR/objdir-tb3/mailnews/imap/src
The following command failed to execute properly:
/usr/bin/ccache /usr/bin/g++-4.9 -fno-builtin-strlen -Wl,--gdb-index -Dfdatasync=fdatasync -DDEBUG=1 -DDEBUG_4GB_CHECK -DUSEHELGRIND=1 -o nsImapProtocol.o -c -I../../../dist/stl_wrappers -I../../../dist/system_wrappers -include /REF-COMM-CENTRAL/comm-central/mozilla/config/gcc_hidden.h -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DMOZ_GLUE_IN_PROGRAM -DOSTYPE="Linux3" -DOSARCH=Linux -DNO_NSPR_10_SUPPORT -I/REF-COMM-CENTRAL/comm-central/mailnews/imap/src -I. -I../../../dist/include -I/REF-OBJ-DIR/objdir-tb3/dist/include/nspr -I/REF-OBJ-DIR/objdir-tb3/dist/include/nss -fPIC -DMOZILLA_CLIENT -include ../../../mozilla-config.h -MD -MP -MF .deps/nsImapProtocol.o.pp -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Werror=int-to-pointer-cast -Werror=type-limits -Wempty-body -Wsign-compare -Wno-invalid-offsetof -Wcast-align -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -pipe -DDEBUG -DTRACING -gsplit-dwarf -g -O2 -freorder-blocks -fno-omit-frame-pointer /REF-COMM-CENTRAL/comm-central/mailnews/imap/src/nsImapProtocol.cpp
/REF-COMM-CENTRAL/comm-central/config/rules.mk:966: recipe for target 'nsImapProtocol.o' failed
make[4]: *** [nsImapProtocol.o] Error 1
make[4]: Target 'target' not remade because of errors.
/REF-COMM-CENTRAL/comm-central/mozilla/config/recurse.mk:82: recipe for target 'mailnews/imap/src/target' failed
make[3]: *** [mailnews/imap/src/target] Error 2
cd util; make libs
cd freebl; make libs

   ...

--- end excerpt

Comment 1

[ISHIKAWA, Chiaki]

I think this is a duplicate of 1071497.
The patch there seems to make TB compile again.
I have no idea why bugzilla did not suggest that 1071497 is similar enough (since it has the function name NS_NewStreamLoader in the title). Anyway marking it as duplicate.